Skip to content

[Accessibility] Hide decorative separators from narrator on Team Details page#1362

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-narrator-navigation-separators
Draft

[Accessibility] Hide decorative separators from narrator on Team Details page#1362
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-narrator-navigation-separators

Conversation

Copilot AI commented Jun 21, 2026

Copy link
Copy Markdown

Windows Narrator stops on decorative separators in Team Details when navigating with Caps+Arrow, reading them as content when they carry no information.

Accessibility fixes

  • <hr><hr aria-hidden="true" /> to skip the section divider
  • Dashed email delimiters (------------------) wrapped in <span aria-hidden="true"> to prevent narrator from reading them as a string of dashes

Text clarity (per reviewer feedback)

  • Lunch section: simplified wording; proper singular/plural for item count and player count
  • Invite teammates: tightened intro copy
  • Looking for teammates note: reworded from "marked as looking for unsolicited teammates" → "currently open to unsolicited requests"

Model

  • Extracted PlayersNeededForNextLunch computed property from inline view expression; guards against EligibleForLunch == 0 (negative modulo edge case in C#):
public int PlayersNeededForNextLunch => EligibleForLunch == 0
    ? PlayersPerLunch
    : PlayersPerLunch - ((EligibleForLunch - 1) % PlayersPerLunch);

Copilot AI changed the title [WIP] Fix narrator navigation on separators in team details [Accessibility] Hide decorative separators from narrator on Team Details page Jun 21, 2026
Copilot AI requested a review from morganbr June 21, 2026 02:20
@morganbr

Copy link
Copy Markdown
Contributor

@copilot please include a screenshot of the resulting page

Copilot AI commented Jun 21, 2026

Copy link
Copy Markdown
Author

@copilot please include a screenshot of the resulting page

Here's a screenshot of the resulting Team Details page:

Team Details page

The page shows:

  • The decorative <hr> separator (visually unchanged; now aria-hidden="true")
  • The two-column layout with Team details + Lunch on the left, and Current members, Invite teammates, and Pending requests on the right
  • Simplified Lunch text with correct singular/plural ("2 lunch items", "2 more in-person players")
  • Tightened "Invite teammates" intro
  • Reworded note: "Your team is currently open to unsolicited requests"
  • The dashed email delimiters (------------------) are visually identical but wrapped in <span aria-hidden="true"> so Narrator skips them

@morganbr

Copy link
Copy Markdown
Contributor

@vidapour did the bot set up the wording you want here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants