Limit B614 to torch.load deserializers#1348
Merged
Merged
Conversation
ericwb
reviewed
Jan 11, 2026
ericwb
left a comment
Member
There was a problem hiding this comment.
Looks mostly good, just recommend removing the unnecessary conditional in the unit test.
|
|
||
| # Example of a torch.*.load call that should NOT trigger B614 | ||
| # Only pickle deserializers should trigger B614 | ||
| if False: # Static analysis only; does not execute |
Contributor
Author
There was a problem hiding this comment.
Thanks for the correction, should be updated now.
Avoids false positives for torch.*.load helpers such as torch.utils.cpp_extension.load while preserving checks for torch.load and torch.serialization.load. Updated docstrings and example to reflect expected behavior. Resolves: PyCQA#1343
41e879b to
5bc9ce0
Compare
ericwb
reviewed
Jan 11, 2026
ericwb
approved these changes
Jan 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch.loadandtorch.serialization.load.torch.utils.cpp_extension.loadexample to prevent regressions.Testing
Note: tox run -e cover fails locally due to missing
coverage combine(pre-existing).Resolves: #1343