Update to Freezeyt 2.0.0 & clean up code#815
Open
encukou wants to merge 1 commit into
Open
Conversation
- Serve "real" HTTP redirects when running as a dynamic site.
(The frozen version uses existing meta redirects.)
- Use the debug setting `PROPAGATE_EXCEPTIONS` rather than
`TRAP_HTTP_EXCEPTIONS`, so that Flask doesn't turn
redirects to errors.
- Pages where the freezer doesn't follow links are handled
with a 'Freezeyt-URL-Finder' header, rather than a custom function
- Remove error for Python 2 (the app uses f-strings, so Python 2
will fail with SyntaxError before it gets to the `raise`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've just released a new version of Freezeyt, which fixes some issues I found when I tried to make pyladies.cz code a bit nicer. (pyladies.cz is Freezeyt's main user today.)
DO these changes make sense?
PROPAGATE_EXCEPTIONSrather thanTRAP_HTTP_EXCEPTIONS, so that Flask doesn't turn redirects to errors.raise)