Documentation Update for NCCL#132
Conversation
mrava87
left a comment
There was a problem hiding this comment.
Just left a few comments on what you have done so far, this needs much more to be ready but hopefully with the checklist that I put in the description of the PR you will have a easier life to navigate the documentation and add bits related to NCCL
mrava87
left a comment
There was a problem hiding this comment.
Very good work @tharittk, I left some additional mostly stylistic comments... once you have address them, I think for now this is already a very good improvement to the documentation to include NCCL related stuff and we can continue revising it as we progress with the code development 🚀
mrava87
left a comment
There was a problem hiding this comment.
@tharittk this looks great to me!
@rohanbabbar04 you want to have a look or shall I go ahead and merge?
Ongoing update - in parallel to NCCL implementation PR (#130)
Tasks
READMEmentioning the possibility to use NCCL instead of MPI for distributed cupy arrays, updating the install, example and tests sections with NCCL-related commandsindex.rstsimilar to README to reflect new NCCL enginegpu.rstdocumenting the new env variable (NCCL_PYLOPS_MPI), adding NCCL to the example, and perhaps consider adding a table like in https://pylops.readthedocs.io/en/stable/gpu.html to document what features are supported in NCCL and what are not, eg the missing support for complex numbers (this can also serve as a live roadmap for you work, as we progress we should see more and more features being supported by both MPI and NCCL)