Fixes #664#667
Merged
Merged
Conversation
mrava87
approved these changes
Jun 7, 2025
mrava87
reviewed
Jun 8, 2025
Collaborator
mrava87
left a comment
mrava87
left a comment
There was a problem hiding this comment.
@cako looks good. Just one question, any reason for >=5, I see we do not have it in requirements-doc.txt.
Btw, I am going to hold on a few days to see if the scikit-fmm problem gets solved and our CI starts to work again... though this PR has no new code so we could merge it anyways
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.