feat: improved used of logging library#687
Merged
Merged
Conversation
Collaborator
Author
|
@cako not sure how familiar you are with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is aimed at improving the use of the
logginglibrary.The most notable change is the removal of all
logging.basicConfig(which should be left to the user application) and the use oflogger = logging.getLogger(__name__)instead.Some of the
logging.errormessages are also removed (as accompanied by a raise exception) and somelogging.warningconverted towarnings.warnbased on the definition of how these two ways of raising a warning compare in https://docs.python.org/3/howto/logging.html)