Skip to content

minor: use pytest.skip instead of return in test_torchoperator #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrava87 merged 3 commits into from
Sep 1, 2025
Merged

minor: use pytest.skip instead of return in test_torchoperator #696

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f689df
minor: use pytest.skip instead of return in test_torchoperator
mrava87 Sep 1, 2025
17c9f35
minor: switch darwin to Darwin
mrava87 Sep 1, 2025
d104cd4
minor: removed print and unused import
mrava87 Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions pytests/test_torchoperator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from numpy.testing import assert_array_equal

backend = "numpy"
import numpy as npp
import pytest
import torch

Expand All @@ -33,7 +32,7 @@ def test_TorchOperator(par):
# temporarily, skip tests on mac as torch seems not to recognized
# numpy when v2 is installed
if platform.system() == "Darwin":
return
pytest.skip("torch not recognized on macOS with numpy v2")
device = "cpu" if backend == "numpy" else "cuda"

Dop = MatrixMult(np.random.normal(0.0, 1.0, (par["ny"], par["nx"])))
Expand Down Expand Up @@ -63,7 +62,7 @@ def test_TorchOperator_batch(par):
# temporarily, skip tests on mac as torch seems not to recognized
# numpy when v2 is installed
if platform.system() == "Darwin":
return
pytest.skip("torch not recognized on macOS with numpy v2")
device = "cpu" if backend == "numpy" else "cuda"

Dop = MatrixMult(np.random.normal(0.0, 1.0, (par["ny"], par["nx"])))
Expand All @@ -85,7 +84,7 @@ def test_TorchOperator_batch_nd(par):
# temporarily, skip tests on mac as torch seems not to recognized
# numpy when v2 is installed
if platform.system() == "Darwin":
return
pytest.skip("torch not recognized on macOS with numpy v2")
device = "cpu" if backend == "numpy" else "cuda"

Dop = MatrixMult(np.random.normal(0.0, 1.0, (par["ny"], par["nx"])), otherdims=(2,))
Expand Down