fix: standard-imghdr is removed from standard library in 3.13#705
Merged
Conversation
Collaborator
|
@cako where do we rely on this? |
Collaborator
Author
|
We don't right now! This is for if we want to ever build docs in 3.13 and above. I was testing on 3.13 and noticed this issue of the library being dropped from stdlib. |
Collaborator
|
Oh right! Well, I am all in favor of keeping the python version high in CI and doc (CI is already supporting 3.13, soon I'll try to see what happens if I add 3.14 😉 )... let me try |
Collaborator
|
Mmh 3.13 fails on intel_mkl: https://app.readthedocs.org/projects/pylops/builds/30058430/ |
mrava87
approved these changes
Oct 23, 2025
Collaborator
mrava87
left a comment
mrava87
left a comment
There was a problem hiding this comment.
Ok, looks like we can't go up to 3.13 yet, but if you agree I am happy to keep your change and bump to 3.12 for now?
Collaborator
Author
|
@mrava87 sounds good! I'll merge this ones for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.