Conversation
|
The ffi crate currently uses Lines 82 to 92 in f57bda7 I can think of two ways to handle this.
The first way is technically a breaking change if anyone is using the |
3f9162a to
48b06f9
Compare
davidhewitt
left a comment
There was a problem hiding this comment.
Thanks, overall this looks good. Couple of suggestions / thoughts / questions about the nontrivial bits.
|
Neat, I'm glad this is mostly mechanical. I'll try to give this a once-over. |
ngoldbaum
left a comment
There was a problem hiding this comment.
I agree with all of David's comments. I also think we need a CI job that compiles the crate with no_std. Might be worth adding that to the nox configuration so all the CI jobs do it if it's a pretty quick build.
The ffi crate will always compile with |
I've added
no_stdto thepython-fficrate.Most of the changes in this PR are a search-and-replace from
std::tocore::. The only other change I've made is in the datetime file. It used theOncetype fromstd. I've updated it to useAtomicBoolinstead.This is the first PR from this converstaion: #5856 (comment)