Skip to content

replace Once-guarded UnsafeCell with AtomicPtr#6026

Merged
davidhewitt merged 1 commit intoPyO3:mainfrom
Person-93:remove_once_from_ffi
May 10, 2026
Merged

replace Once-guarded UnsafeCell with AtomicPtr#6026
davidhewitt merged 1 commit intoPyO3:mainfrom
Person-93:remove_once_from_ffi

Conversation

@Person-93
Copy link
Copy Markdown
Contributor

Removes Once from the ffi crate as discussed #6022 (comment)

@Person-93 Person-93 force-pushed the remove_once_from_ffi branch from 7cfaa1d to 535b8f3 Compare May 10, 2026 03:51
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 10, 2026

Merging this PR will improve performance by 15.36%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 104 untouched benchmarks
⏩ 1 skipped benchmark1

Performance Changes

Benchmark BASE HEAD Efficiency
bench_pyclass_create 4.6 µs 4 µs +15.36%

Comparing Person-93:remove_once_from_ffi (535b8f3) with main (901b032)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label May 10, 2026
Copy link
Copy Markdown
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidhewitt davidhewitt added this pull request to the merge queue May 10, 2026
Merged via the queue into PyO3:main with commit 526c690 May 10, 2026
46 of 47 checks passed
@Person-93 Person-93 deleted the remove_once_from_ffi branch May 10, 2026 12:46
pull Bot pushed a commit to rsoorajs/pyo3 that referenced this pull request May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-skip-changelog Skip checking changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants