internal: [codex] try fix mingw libname#6164
Conversation
usually mingw version of python are shipped with `lib` prefix, so we need to add it for proper linking
|
@ognevny can you try in this Git branch? |
|
IIUC you just let the agent fix the things? I'll try to cherry-pick some good changes if I find them |
yes |
|
this time ai was smarter than me. I just forgot about dot separating major and minor version! that could be an issue... |
|
your branch didn't work too... https://github.com/msys2/MINGW-packages/actions/runs/28259458928/job/83730859317?pr=29942 |
|
maybe this? |
|
сodex went a bit overboard, but I hope it will help clarify the problem itself |
|
it worked! but the latest change seem to be a workaround... anyway I'll give up with my branch |
You can add fix to your branch; the main issue is that we need to test these builds in CI |
I closed my PR. anyway my was different only in a kind of style, so I'll let maintainers review your change |
|
oh I didn't see you wrote comments on the same lines 😅 |
|
@ognevny сould you take another look? I'm not sure about some of comments, since I haven't worked with MINGW |
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
There was a problem hiding this comment.
as if this test weren't necessary either
|
fine with the comments, but you seem to duplicate them in one place |
No description provided.