fix: implement is_exact_type_of to check dtype and shape for PyArray#550
Open
asjad2401 wants to merge 1 commit into
Open
fix: implement is_exact_type_of to check dtype and shape for PyArray#550asjad2401 wants to merge 1 commit into
asjad2401 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PyTypeInfo::is_exact_type_ofwas not overridden forPyArray<T, D>, so thedefault PyO3 implementation (a plain Python type object pointer comparison) was
used. This caused
cast_exactanddowncast_exactto ignore element dtype andarray dimensionality — a float32 array would silently pass a
cast_exact::<PyArray2<f64>>()check.Reported in #549, also related to #547.
Fix
Override
is_exact_type_ofwith the same implementation asis_type_of, whichcalls
Self::extractinternally. This checks:DTTest
Added
cast_exact_checks_dtype_and_shapetotests/array.rswhich verifies:cast_exactsucceeds when both dtype and shape matchcast_exactfails when dtype does not matchcast_exactfails when dimensionality does not match