fix: CBC output parsing, parse runtime & duality gap#446
Merged
siddharth-krishna merged 3 commits intoPyPSA:masterfrom Apr 25, 2025
Merged
fix: CBC output parsing, parse runtime & duality gap#446siddharth-krishna merged 3 commits intoPyPSA:masterfrom
siddharth-krishna merged 3 commits intoPyPSA:masterfrom
Conversation
FabianHofmann
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
If CBC is run with the solver options
{"ratioGap": mip_gap}, then the solution file it produces has a different headercompared to what the current code expects:
This causes linopy to incorrectly return a
warningstatus without any objective value or other solution information. This PR updates the solution parser to be more robust.I've also taken this opportunity to upgrade the CBC wrapper so that it parses the stdout of CBC and returns information on the solver runtime and the MIP duality gap. (Information we need for the solver benchmark.)
Checklist
doc.doc/release_notes.rstof the upcoming release is included.