Bugfix pypsa eur as snakemake module (#1967)

* Fix Bug 1: Resolve double prefixing caused by f-string coercion.

* Fix Bug 2: Rule retrieve_co2stop not saving files in correct location.
Fix by making filepaths relative to an input or output location.

* Fix Bug 3: make filepaths in rule retrieve_corine relative to the zip_file in `input`

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Updated release notes

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 2 people

rules/build_electricity.smk

@@ -268,7 +268,7 @@ rule determine_availability_matrix:
         renewable=config_provider("renewable"),
     input:
         unpack(input_ua_md_availability_matrix),
-        corine=ancient(f"{rules.retrieve_corine.output['tif_file']}"),
+        corine=ancient(rules.retrieve_corine.output["tif_file"]),
         natura=lambda w: (
             f"{NATURA_DATASET["folder"]}/natura.tiff"
             if config_provider("renewable", w.technology, "natura")(w)

rules/retrieve.smk

@@ -84,8 +84,7 @@ if (CORINE_DATASET := dataset_version("corine"))["source"] in ["archive"]:
             unpack_archive(input["zip_file"], output_folder)
             copy2(input["zip_file"], output["zip_file"])
             copy2(
-                f"{CORINE_DATASET['folder']}/corine/g250_clc06_V18_5.tif",
-                output["tif_file"],
+                f"{output_folder}/corine/g250_clc06_V18_5.tif", output["tif_file"]
             )
 
 elif (CORINE_DATASET := dataset_version("corine"))["source"] in ["primary"]:
@@ -615,8 +614,10 @@ if (CO2STOP_DATASET := dataset_version("co2stop"))["source"] in [
             traps_table3=f"{CO2STOP_DATASET['folder']}/CO2JRC_OpenFormats/CO2Stop_DataInterrogationSystem/Hydrocarbon_Traps1.csv",
             traps_map=f"{CO2STOP_DATASET['folder']}/CO2JRC_OpenFormats/CO2Stop_Polygons Data/DaughterUnits_March13.kml",
         run:
+            output_folder = Path(output["zip_file"]).parent
+            output_folder.mkdir(parents=True, exist_ok=True)
             copy2(input["zip_file"], output["zip_file"])
-            unpack_archive(output["zip_file"], CO2STOP_DATASET["folder"])
+            unpack_archive(output["zip_file"], output_folder)
 
 
 if (GEM_EUROPE_GAS_TRACKER_DATASET := dataset_version("gem_europe_gas_tracker"))[