Maintenance: improve iiasa_database handling, update_config_from_wildcards, raise errors#102
Merged
Maintenance: improve iiasa_database handling, update_config_from_wildcards, raise errors#102
Conversation
* require retrieve config to be active * relocate ariadne_databse from resources to data * remove unused params from some rules
lindnemi
changed the title
lindnemi
changed the title
Collaborator
Author
|
Collaborator
Author
|
Es waren neue Warnings aufgetaucht mit pypsa 0.35.1 deswegen habe ich die imports in plot_hydrogen_network_incl_kernnetz geändert |
lkstrp
approved these changes
Sep 19, 2025
Member
lkstrp
left a comment
lkstrp
left a comment
There was a problem hiding this comment.
Sorry for the missed review. This is some lovely clean up! Moving the ariadne database hopefully also resolves my CI problems
| logger.error( | ||
| f"CO2 budget for countries other than `DE` is not yet supported. Found country {ct}. Please check the config file." | ||
| ) | ||
| raise NotImplementedError( |
Member
There was a problem hiding this comment.
Do we do that in Eur as well?
I'm not 100% sure if there was a reason to log errors instead of raising them with snakemake. I guess at the end it will not make a difference, since snakemake will either fail because a file is missing or because an error is raised, which will be more informative
| ) | ||
| except KeyError: | ||
| print( | ||
| logger.info( |
Member
There was a problem hiding this comment.
logger.warning instead of logger.info("warning: ..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are:
iiasa_database:topypsa-de:in configBefore asking for a review for this PR make sure to complete the following checklist:
ariadne_allcompletes without errorsexport_ariadne_variableshas been adapted to the changesChangelog.mdmainhas been merged into the PRYYYYMMDDdescriptive_title