You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Before asking for a review for this PR make sure to complete the following checklist:
Workflow with target rule ariadne_all completes without errors
The logic of export_ariadne_variables has been adapted to the changes
One or several figures that validate the changes in the PR have been posted as a comment
A brief description of the changes has been added to Changelog.md
The latest main has been merged into the PR
The config has a new prefix of the format YYYYMMDDdescriptive_title
A minor change to prevent PyPSA-AT CI tests from failing with <Signals.SIGTERM: 15> (=out of memory) in rule build_existing_chp_de. Here is an example for a failed testrun due to memory problems. Setting a resource limit for build_existing_chp_de fixes the issue.
Sorry, I did not run the full PyPSA-DE workflow. If you require more checked boxes, let me know and I'll see to it in the next couple of days.
I see that the PyPSA-DE pipeline fails due to out-of-space errors. I fixed that for PyPSA-AT with
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
with:
# Remove tools that are not needed
tool-cache: false
android: true
dotnet: true
haskell: true
large-packages: false
docker-images: true
swap-storage: true
The action frees up ~21 GB disk space on the runner VM and takes around 30 seconds to complete. This PR does not contain this fix!
Furthermore, I migrated all tests to pixi for simplicity. Python packages are not cached anymore and install using the pixi.lock within ~30 sec. The benefit is a radically simplified workflow.
I see that the PyPSA-DE pipeline fails due to out-of-space errors. I fixed that for PyPSA-AT with
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
with:
# Remove tools that are not needed
tool-cache: false
android: true
dotnet: true
haskell: true
large-packages: false
docker-images: true
swap-storage: true
The action frees up ~21 GB disk space on the runner VM and takes around 30 seconds to complete. This PR does not contain this fix!
Furthermore, I migrated all tests to pixi for simplicity. Python packages are not cached anymore and install using the pixi.lock within ~30 sec. The benefit is a radically simplified workflow.
This sounds very promising! @lkstrp could you take a look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before asking for a review for this PR make sure to complete the following checklist:
ariadne_allcompletes without errorsexport_ariadne_variableshas been adapted to the changesChangelog.mdmainhas been merged into the PRYYYYMMDDdescriptive_titleA minor change to prevent PyPSA-AT CI tests from failing with
<Signals.SIGTERM: 15>(=out of memory) in rulebuild_existing_chp_de. Here is an example for a failed testrun due to memory problems. Setting a resource limit forbuild_existing_chp_defixes the issue.Sorry, I did not run the full PyPSA-DE workflow. If you require more checked boxes, let me know and I'll see to it in the next couple of days.