use higher lifetime only for existing German gas CHPs#90
Merged
Conversation
This reverts commit ea88245.
cpschau
requested changes
Jul 11, 2025
Contributor
cpschau
left a comment
cpschau
left a comment
There was a problem hiding this comment.
Code looks good to me! Only two comments:
- A comment that states assumptions for 40 year lifetime might be helpful. Making it a configurable setting would be the icing on the cherry on the cake.
- Do we want to keep the Changelog? If yes we would need another entry.
I am not entirely sure about the fill value of 40 years, as it sounds quite optimistic for me comparing it to other sources (DEA assumes 25 years). Taking a look into the data it also seems as if there were a couple of smaller CHP plants that had a way shorter lifetime than 25 years. Not sure if they were actually decommissioned or maybe re-registered with a different ID.
cpschau
approved these changes
Jul 14, 2025
Contributor
cpschau
left a comment
cpschau
left a comment
There was a problem hiding this comment.
LGTM! Feel free to leave the refactoring of params call to a dedicated PR.
toniseibold
pushed a commit
to toniseibold/pypsa-de
that referenced
this pull request
Jul 15, 2025
* use higher lifetime only for existing German gas CHPs * actually use adjusted lifetime when asset is created * Revert "disable chps from prepare_sector_network" This reverts commit ea88245. * use pivot_table weighted by capacity to determine lifetimes * remove old comments * remove unused dropna * make NA values for existing gas CHPs a config setting * add changelog note * use all lower case for config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final Summary of changes:
the issue was more complex than I thought. This were some to dos:
Original issue description
During the validation of the electricity sector we noticed that there were not enough gas CHPs in the data, see PyPSA/pypsa-ariadne#285
This is partially because the DateOut of many CHPs in german_chps.csv is missing, s.t. a default lifetime of 25 years was assumed. However, as some manual checks @JulianGeis revealed, many of the CHPs remain in operation after 25 years-
To improve the representation of these assets the lifetime of gas CHPs was extended to 40 years. However, the way it was done, this also affects newly built gas CHPs, reducing their annuities. This PR keeps the lifetime extension for existing assets, but removes it for new ones.
Before asking for a review for this PR make sure to complete the following checklist:
ariadne_allcompletes without errorsexport_ariadne_variableshas been adapted to the changesChangelog.mdmainhas been merged into the PRYYYYMMDDdescriptive_title