Skip to content

Commit da200f6

Browse files
author
domosedy
committed
[refactor] rebase from master
1 parent 3ea8f9a commit da200f6

3 files changed

Lines changed: 2 additions & 10 deletions

File tree

src/pysatl_core/families/exponential_family.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@
99
from scipy.integrate import nquad
1010
from scipy.linalg import det
1111

12-
from pysatl_core.distributions import (
13-
SamplingStrategy,
14-
)
1512
from pysatl_core.distributions.support import (
1613
ContinuousSupport,
1714
SupportByPredicate,
@@ -73,7 +70,6 @@ def __init__(
7370
name: str = "ExponentialFamily",
7471
distr_type: DistributionType | Callable[[Parametrization], DistributionType],
7572
distr_parametrizations: list[ParametrizationName],
76-
sampling_strategy: SamplingStrategy,
7773
support_by_parametrization: SupportArg = None,
7874
):
7975
self._sufficient = sufficient_statistics
@@ -99,7 +95,6 @@ def __init__(
9995
distr_type=distr_type,
10096
distr_parametrizations=distr_parametrizations,
10197
distr_characteristics=distr_characteristics,
102-
sampling_strategy=sampling_strategy,
10398
support_by_parametrization=support_by_parametrization,
10499
)
105100
parametrization(family=self, name="theta")(ExponentialFamilyParametrization)
@@ -137,7 +132,6 @@ def conjugate_sufficient(
137132

138133
if theta not in self._parameter_space:
139134
return np.full(len(theta) + 1, float("-inf"))
140-
# print("Current sufficient:", theta, self._log_partition(theta))
141135
return np.append(theta, self._log_partition(theta))
142136

143137
def conjugate_log_partition(
@@ -178,7 +172,6 @@ def conjugate_sufficient_accepts(
178172
sufficient_statistics_values=self._parameter_space, # TODO: write convex hull for this
179173
parameter_space=SupportByPredicate(conjugate_sufficient_accepts), # type: ignore[arg-type]
180174
name=self.name,
181-
sampling_strategy=self.sampling_strategy,
182175
distr_type=self._distr_type,
183176
distr_parametrizations=self.parametrization_names,
184177
support_by_parametrization=self.support_resolver,
@@ -213,7 +206,6 @@ def new_normalization(x: Any) -> Any:
213206
name=f"Transformed{self._name}",
214207
distr_type=self._distr_type,
215208
distr_parametrizations=self.parametrization_names,
216-
sampling_strategy=self.sampling_strategy,
217209
support_by_parametrization=self.support_resolver,
218210
)
219211

src/pysatl_core/types.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,8 @@ def shape(self) -> ContinuousSupportShape1D:
240240

241241
type Method[In, Out] = AnalyticalComputation[In, Out] | FittedComputationMethod[In, Out]
242242
"""Type alias for a distribution computation method (analytical or fitted)."""
243+
244+
243245
@dataclass(frozen=True, slots=True)
244246
class IntervalND:
245247
intervals: list[Interval1D]

tests/unit/families/test_exponential_family.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import scipy
66
from numpy.testing import assert_allclose
77

8-
from pysatl_core.distributions.strategies import DefaultSamplingUnivariateStrategy
98
from pysatl_core.distributions.support import ContinuousNDSupport, SupportByIntervals
109
from pysatl_core.families import (
1110
ContinuousExponentialClassFamily,
@@ -36,7 +35,6 @@ def transform_function(x: list[float] | float) -> list[float] | float:
3635
support=support_pos,
3736
distr_type=UnivariateContinuous,
3837
distr_parametrizations=["theta"],
39-
sampling_strategy=DefaultSamplingUnivariateStrategy(),
4038
)
4139

4240
conjugate_fam = fam.conjugate_prior_family.transform(transform_function)

0 commit comments

Comments
 (0)