Fitters.py refactoring#76
Merged
Merged
Conversation
Closed
LeonidElkin
requested changes
Apr 13, 2026
Collaborator
LeonidElkin
left a comment
LeonidElkin
left a comment
There was a problem hiding this comment.
- Universal options (calculations) of the characteristic should be passed to
query_methodand stick out explicitly for the user as a public API instead of the current**options: Any. @Desiment will describe the use cases in more detail in the PR or personally - The strategy assumes responsibility for passing options to
ComputationMethod. If no changes have been made by the user, we leave the defaults.
siwreienta
force-pushed
the
fitters-refactor
branch
2 times, most recently
from
f988423 to
8bb1996
Compare
LeonidElkin
requested changes
May 1, 2026
LeonidElkin
added
API: Consistency
siwreienta
force-pushed
the
fitters-refactor
branch
3 times, most recently
from
a8ed14f to
5bb91ad
Compare
LeonidElkin
reviewed
May 3, 2026
Collaborator
LeonidElkin
left a comment
LeonidElkin
left a comment
There was a problem hiding this comment.
It's much better than it was before, but there are still a couple of issues that were discussed but not resolved.
Also, don't forget to make jupiter notebook in the examples/ folder
…eparate characteristic and computation options
…d computation option handling
…s and execution plans
…methods handle edge cases correctly, and the dead code is removed
siwreienta
force-pushed
the
fitters-refactor
branch
from
5bb91ad to
4acddb8
Compare
… strategies and their caching
siwreienta
force-pushed
the
fitters-refactor
branch
2 times, most recently
from
7625613 to
4fb8281
Compare
…ns, fitters and other computational units
siwreienta
force-pushed
the
fitters-refactor
branch
from
4fb8281 to
3be21eb
Compare
Desiment
previously approved these changes
May 6, 2026
LeonidElkin
requested changes
May 6, 2026
Collaborator
LeonidElkin
left a comment
LeonidElkin
left a comment
There was a problem hiding this comment.
The example is not the best, but in general is ok
…e checks have been added + test covering
siwreienta
force-pushed
the
fitters-refactor
branch
from
d8c1ce8 to
df79374
Compare
LeonidElkin
approved these changes
May 7, 2026
Desiment
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.