Skip to content

Score function for builtins#84

Merged
MyznikovFD merged 1 commit into
mainfrom
score-function
May 2, 2026
Merged

Score function for builtins#84
MyznikovFD merged 1 commit into
mainfrom
score-function

Conversation

@MyznikovFD
Copy link
Copy Markdown
Collaborator

@MyznikovFD MyznikovFD commented Apr 5, 2026 •
edited
Loading

Add score (log‑PDF gradient) for built‑in distribution families

Implement base_score for the base parametrization of Normal, Exponential, Uniform.

Add gradient_transform to parametrization classes to propagate gradients via chain rule.

Provide a unified score method in ParametricFamily that works for all parametrizations.

Include parametrized tests verifying shape, type, and consistency across parametrizations.

@MyznikovFD MyznikovFD self-assigned this Apr 5, 2026
@MyznikovFD MyznikovFD added Enhancement New feature or request core.families labels Apr 5, 2026
@MyznikovFD MyznikovFD moved this to In review in PySATL Core Developing Apr 5, 2026
@Desiment Desiment changed the title Score function for builtins, implemented as a characteristick Score function for builtins, implemented as a characteristic Apr 6, 2026
@LeonidElkin
Copy link
Copy Markdown
Collaborator

LeonidElkin commented Apr 6, 2026

Change feature to feat in 86f5e49 commit message

Desiment
Desiment requested changes Apr 6, 2026
View reviewed changes
Comment thread src/pysatl_core/families/builtins/continuous/exponential.py Outdated
Comment thread src/pysatl_core/families/builtins/continuous/normal.py Outdated
Comment thread src/pysatl_core/types.py Outdated
Comment thread src/pysatl_core/families/builtins/continuous/uniform.py Outdated
Comment thread tests/unit/families/builtins/continuous/test_normal.py Outdated
@MyznikovFD MyznikovFD force-pushed the score-function branch 2 times, most recently from 3ade91a to 1ddd173 Compare April 10, 2026 15:15
@MyznikovFD MyznikovFD requested a review from Desiment April 10, 2026 15:15
LeonidElkin
LeonidElkin requested changes Apr 13, 2026
View reviewed changes
Comment thread src/pysatl_core/types.py Outdated
Comment thread src/pysatl_core/families/builtins/continuous/normal.py Outdated
@MyznikovFD MyznikovFD requested a review from LeonidElkin April 16, 2026 08:57
@MyznikovFD MyznikovFD changed the title Score function for builtins, implemented as a characteristic Score function for builtins, implemented as a characteristic + partial fixing of parameters Apr 17, 2026
LeonidElkin
LeonidElkin reviewed Apr 17, 2026
View reviewed changes
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
Comment thread src/pysatl_core/families/parametric_family.py Outdated
@MyznikovFD MyznikovFD changed the title Score function for builtins, implemented as a characteristic + partial fixing of parameters Score function for builtins, implemented as a characteristic Apr 20, 2026
@MyznikovFD MyznikovFD force-pushed the score-function branch 2 times, most recently from 88f2433 to 2d2bd52 Compare April 20, 2026 17:41
LeonidElkin
LeonidElkin previously approved these changes Apr 20, 2026
View reviewed changes
Desiment
Desiment requested changes Apr 20, 2026
View reviewed changes
Comment thread src/pysatl_core/families/builtins/continuous/exponential.py Outdated
Comment thread src/pysatl_core/families/builtins/continuous/exponential.py Outdated
Comment thread src/pysatl_core/families/builtins/continuous/exponential.py Outdated
LeonidElkin
LeonidElkin requested changes Apr 27, 2026
View reviewed changes
Comment thread tests/unit/families/builtins/continuous/test_normal.py Outdated
@MyznikovFD MyznikovFD force-pushed the score-function branch 3 times, most recently from e2da9a0 to c40b94b Compare April 27, 2026 17:35
@MyznikovFD MyznikovFD changed the title Score function for builtins, implemented as a characteristic Score function for builtins Apr 27, 2026
LeonidElkin
LeonidElkin requested changes Apr 28, 2026
View reviewed changes
Comment thread tests/unit/families/builtins/continuous/test_normal.py Outdated
@MyznikovFD MyznikovFD force-pushed the score-function branch 2 times, most recently from 732d55e to 549809d Compare April 30, 2026 18:36
@MyznikovFD MyznikovFD merged commit 937137c into main May 2, 2026
14 checks passed
@MyznikovFD MyznikovFD deleted the score-function branch May 2, 2026 18:18
@github-project-automation github-project-automation Bot moved this from In review to Done in PySATL Core Developing May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Desiment Desiment Desiment approved these changes

@LeonidElkin LeonidElkin LeonidElkin approved these changes

Assignees

@MyznikovFD MyznikovFD

Labels

core.families Enhancement New feature or request

Projects

PySATL Core Developing
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MyznikovFD @LeonidElkin @Desiment