fix: bug in benchmark executor with saving registry

Author: iraedeus

pysatl_cpd/benchmark/core/benchmark_executor.py

@@ -178,20 +178,20 @@ def execute(self) -> list[tuple[BenchmarkRecord, OnlineDetectionTrace[Any]]]:
 
                 results.append((record, trace))
 
-            if registry_path is not None:
-                fieldnames = ["algorithm", "configuration_hash", "data", "threshold", "trace_path"]
-                with open(registry_path, mode="w", encoding="utf-8", newline="") as f:
-                    writer = csv.DictWriter(f, fieldnames=fieldnames)
-                    writer.writeheader()
-                    for rec in registry.values():
-                        writer.writerow(
-                            {
-                                "algorithm": rec.algorithm,
-                                "configuration_hash": rec.configuration_hash,
-                                "data": rec.data,
-                                "threshold": rec.threshold,
-                                "trace_path": rec.trace_path or "",
-                            }
-                        )
+        if registry_path is not None:
+            fieldnames = ["algorithm", "configuration_hash", "data", "threshold", "trace_path"]
+            with open(registry_path, mode="w", encoding="utf-8", newline="") as f:
+                writer = csv.DictWriter(f, fieldnames=fieldnames)
+                writer.writeheader()
+                for rec in registry.values():
+                    writer.writerow(
+                        {
+                            "algorithm": rec.algorithm,
+                            "configuration_hash": rec.configuration_hash,
+                            "data": rec.data,
+                            "threshold": rec.threshold,
+                            "trace_path": rec.trace_path or "",
+                        }
+                    )
 
         return results

pysatl_cpd/benchmark/metrics/classification/classification_report.py

@@ -57,6 +57,4 @@ def aggregate(self, values: Sequence[dict[str, float]]) -> dict[str, float]:
         recall = total_tp / (total_tp + total_fn) if (total_tp + total_fn) > 0 else 0.0
         f1 = 2 * precision * recall / (precision + recall) if (precision + recall) > 0 else 0.0
 
-        print(total_fp)
-
         return {"tp": total_tp, "fp": total_fp, "fn": total_fn, "precision": precision, "recall": recall, "f1": f1}