[StatsBomb] Fix player identity inference issues in freeze frame data#386
Merged
Conversation
probberechts
changed the title
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I was trying to use freeze frame data from statsbomb and I think I encountered a couple of small bugs in how player information was connected to the player tracking data. First, there seems to be an issue when getting player positions if a player hasn't been subbed in yet, which I resolved by catching the error and just continuing. Then there's a timing issue when deserializing the data, where position information doesn't seem to be added until the
EventDatasetis created. I resolved that issue by postponing setting the freeze frame data until after theEventDatasetis initialized.I wasn't sure exactly how the unit tests are laid out, so I added a test for each apparent bug in the
test_statsbombtest module, let me know if there's a better place for them. Also, I have no idea if this is the right way to solve these issues (or whether it's about to be obviated by the changes in #377), so please feel free to let me know if there's another way to do it or just close the PR; I just figured I should share my workarounds for the problems I had in case they're more broadly helpful.