feat: add tests for task, task cancellation, fix sender tests

Author: Nigma-Ks

backend/utils/tests/test_cancel.py

@@ -0,0 +1,80 @@
+import subprocess
+from unittest.mock import call, patch
+
+import pytest
+from fastapi.testclient import TestClient
+
+from backend.config.paths import get_tmp_thread_files
+from backend.main import app
+
+client = TestClient(app)
+
+TASK_UID = "abc123"
+
+
+@pytest.fixture
+def mock_cancel_deps():
+    """Patch all three side-effects of the cancel endpoint."""
+    with (
+        patch("backend.main.celery_app") as mock_celery,
+        patch("backend.main.subprocess.run") as mock_subproc,
+        patch("backend.main.shutil.rmtree") as mock_rmtree,
+    ):
+        yield {
+            "celery": mock_celery,
+            "subprocess": mock_subproc,
+            "rmtree": mock_rmtree,
+        }
+
+
+def test_cancel_returns_200(mock_cancel_deps):
+    response = client.post(f"/api/cancel/{TASK_UID}")
+    assert response.status_code == 200
+
+
+def test_cancel_response_body(mock_cancel_deps):
+    response = client.post(f"/api/cancel/{TASK_UID}")
+    data = response.json()
+    assert data["status"] == "cancelled"
+    assert data["task_uid"] == TASK_UID
+
+
+def test_cancel_revokes_celery_task(mock_cancel_deps):
+    client.post(f"/api/cancel/{TASK_UID}")
+    mock_cancel_deps["celery"].control.revoke.assert_called_once_with(TASK_UID)
+
+
+def test_cancel_stops_docker_container(mock_cancel_deps):
+    client.post(f"/api/cancel/{TASK_UID}")
+    mock_cancel_deps["subprocess"].assert_called_once_with(
+        ["docker", "stop", f"pysymbench-{TASK_UID}"],
+        check=False,
+        capture_output=True,
+        timeout=30,
+    )
+
+
+def test_cancel_removes_all_tmp_dirs(mock_cancel_deps):
+    client.post(f"/api/cancel/{TASK_UID}")
+    expected_paths = get_tmp_thread_files(TASK_UID)
+    calls = [call(p, ignore_errors=True) for p in expected_paths]
+    mock_cancel_deps["rmtree"].assert_has_calls(calls, any_order=True)
+    assert mock_cancel_deps["rmtree"].call_count == len(expected_paths)
+
+
+def test_cancel_still_succeeds_when_docker_stop_fails(mock_cancel_deps):
+    """docker stop returning non-zero exit (container not running) must not raise."""
+    mock_cancel_deps["subprocess"].return_value = subprocess.CompletedProcess(
+        args=[], returncode=1
+    )
+    response = client.post(f"/api/cancel/{TASK_UID}")
+    assert response.status_code == 200
+    assert response.json()["status"] == "cancelled"
+
+
+def test_cancel_different_uids_use_correct_container_name(mock_cancel_deps):
+    for uid in ["uid-one", "uid-two"]:
+        mock_cancel_deps["subprocess"].reset_mock()
+        client.post(f"/api/cancel/{uid}")
+        args = mock_cancel_deps["subprocess"].call_args[0][0]
+        assert args[-1] == f"pysymbench-{uid}"

backend/utils/tests/test_result_sender.py

@@ -74,7 +74,7 @@ def test_send_folder_by_email_success(
         assert "file2.txt" in file_list
         assert "subfolder/file3.txt" in file_list
 
-    mock_smtp.assert_called_once_with("smtp.gmail.com", 587, timeout=30)
+    mock_smtp.assert_called_once_with("smtp.gmail.com", 587, timeout=15)
     mock_server_instance.ehlo.assert_called()
     mock_server_instance.starttls.assert_called_once()
     mock_server_instance.login.assert_called_once_with(
@@ -240,4 +240,4 @@ def test_email_content_structure(
 
     attachment = sent_msg.get_payload()[1]
     assert attachment.get_content_type() == "application/zip"
-    assert attachment.get_filename() == "results"
+    assert attachment.get_filename() == "results.zip"

backend/utils/tests/test_task.py

@@ -0,0 +1,58 @@
+from unittest.mock import MagicMock
+
+import pytest
+from fastapi.testclient import TestClient
+
+from backend.main import app
+from backend.utils import task as task_module
+
+client = TestClient(app)
+
+TASK_UID = "abc123"
+
+
+@pytest.fixture
+def mock_task_deps(monkeypatch):
+    mock_run = MagicMock()
+    mock_send = MagicMock()
+    mock_reset = MagicMock()
+    mock_get_files = MagicMock(return_value=["/tmp/fake/uploads", "/tmp/fake/results"])
+
+    monkeypatch.setattr(task_module, "run_pipeline", mock_run)
+    monkeypatch.setattr(task_module, "send_folder_by_email", mock_send)
+    monkeypatch.setattr(task_module, "reset_dirs", mock_reset)
+    monkeypatch.setattr(task_module, "get_tmp_thread_files", mock_get_files)
+
+    return {
+        "run_pipeline": mock_run,
+        "send_email": mock_send,
+        "reset_dirs": mock_reset,
+        "get_tmp_thread_files": mock_get_files,
+    }
+
+
+def test_task_cleanup_runs_on_success(mock_task_deps):
+    task_module.process_and_cleanup_task.run(TASK_UID, "a@b.com", "exp", "model.onnx")
+    mock_task_deps["reset_dirs"].assert_called_once()
+
+
+def test_task_cleanup_runs_on_pipeline_failure(mock_task_deps):
+    mock_task_deps["run_pipeline"].side_effect = RuntimeError("docker died")
+    task_module.process_and_cleanup_task.run(TASK_UID, "a@b.com", "exp", "model.onnx")
+    mock_task_deps["reset_dirs"].assert_called_once()
+
+
+def test_task_no_email_on_pipeline_failure(mock_task_deps):
+    mock_task_deps["run_pipeline"].side_effect = RuntimeError("docker died")
+    task_module.process_and_cleanup_task.run(TASK_UID, "a@b.com", "exp", "model.onnx")
+    mock_task_deps["send_email"].assert_not_called()
+
+
+def test_task_sends_email_on_success(mock_task_deps):
+    task_module.process_and_cleanup_task.run(TASK_UID, "a@b.com", "exp", "model.onnx")
+    mock_task_deps["send_email"].assert_called_once()
+
+
+def test_task_cleanup_receives_correct_uid(mock_task_deps):
+    task_module.process_and_cleanup_task.run(TASK_UID, "a@b.com", "exp", "model.onnx")
+    mock_task_deps["get_tmp_thread_files"].assert_called_once_with(TASK_UID)