Merge pull request #1358 from bact/fix-lunar-last-day

Raise errors when get unsupported value / instance not ready

Author: bact

pythainlp/tokenize/budoux.py

@@ -56,6 +56,9 @@ def segment(text: str) -> list[str]:
             _parser = _init_parser()
         parser = _parser
 
+    if parser is None:
+        raise RuntimeError("Failed to initialize BudouX parser")
+
     result = cast("list[str]", parser.parse(text))
 
     return result

pythainlp/transliterate/thai2rom.py

@@ -245,6 +245,10 @@ def forward(
                 attn_energies,
                 self.other.unsqueeze(0).expand(*hidden.size()).transpose(1, 2),
             ).squeeze(2)
+        else:
+            raise ValueError(
+                f"Unsupported attention method: {self.method!r}"
+            )
 
         attn_energies = attn_energies.masked_fill(mask == 0, -1e10)
 

pythainlp/transliterate/thaig2p.py

@@ -267,6 +267,10 @@ def forward(
                 attn_energies,
                 self.other.unsqueeze(0).expand(*hidden.size()).transpose(1, 2),
             ).squeeze(2)
+        else:
+            raise ValueError(
+                f"Unsupported attention method: {self.method!r}"
+            )
 
         attn_energies = attn_energies.masked_fill(mask == 0, -1e10)
 

pythainlp/util/thai_lunar_date.py

@@ -407,8 +407,14 @@ def to_lunar_date(input_date: date) -> str:
         days_in_month = _DAYS_355
     elif last_day == 384:
         days_in_month = _DAYS_384
+    else:
+        raise ValueError(
+            f"Unexpected last_day value: {last_day!r}. "
+            "Expected 354, 355, or 384."
+        )
 
     days_of_year = day_from_one
+    th_m = 0
     for j, days in enumerate(days_in_month, start=1):
         th_m = j
         if 0 < days_of_year <= days: