|
6 | 6 | <https://github.com/PyThaiNLP/pythainlp/blob/dev/tests/README.md>. |
7 | 7 | The document list test categories, their dependency sets, |
8 | 8 | and test naming conventions. |
9 | | -- [ ] Use reStructuredText for docstring (PEP 287), targetting Sphinx. |
| 9 | +- [ ] Use reStructuredText for docstring (PEP 287), targeting Sphinx. |
10 | 10 | - [ ] When possible, follow NLTK established convention of submodule |
11 | 11 | name (tend to be a verb or a generic noun), function name, and |
12 | 12 | configuration. Communicate this to the users during code review. |
|
20 | 20 | the repo. Read its usage and information it generates at |
21 | 21 | <https://github.com/PyThaiNLP/pythainlp/blob/dev/build_tools/analysis/README.md>. |
22 | 22 | Mind that the analyzer can create false positives, |
23 | | - please refer to Python tyep specification when in doubt. |
| 23 | + please refer to Python type specification when in doubt. |
24 | 24 | - [ ] Complete type annotations for function, method, class, variable, etc. |
25 | 25 | Maintain near-100% type annotation coverage. |
26 | 26 | - [ ] Add tests for new functionality or behavior. |
|
31 | 31 | - [ ] Major changes should be logged in the change log at |
32 | 32 | <https://github.com/PyThaiNLP/pythainlp/blob/dev/CHANGELOG.md>. |
33 | 33 | Provide issue number or PR number if available. |
| 34 | +- [ ] Do not use os.path.join(); |
| 35 | + always use pythainlp.tools.safe_path_join() instead, |
| 36 | + to prevent path traversal vulnerabilities (CWE-22). |
34 | 37 |
|
35 | 38 | ## Project contribution guidelines |
36 | 39 |
|
|
0 commit comments