I notice that there are additional base requirements added when bumping from 5.1.2 to 5.2.0
The PYYAML, PANDAS and NUMPY
|
requirements = [ |
|
"backports.zoneinfo; python_version<'3.9'", |
|
"requests>=2.31", |
|
PYYAML, |
|
PANDAS, |
|
NUMPY, |
|
"tzdata; sys_platform == 'win32'", |
|
] |
As I walk through the changes in v5.1.2...v5.2.0, I don't see any particular changes that we need to add it as a base requirement and it adds additional 79Mb when building Dockerfile. After investigating, it seems to be added in #1154 to fix the CLI problem. Since pythainlp is mostly use as a library (import) not as much as CLI. Should we add additional extra (pythainlp[cli]) instead to cope with this?
I notice that there are additional base requirements added when bumping from
5.1.2to5.2.0The
PYYAML,PANDASandNUMPYpythainlp/setup.py
Lines 45 to 52 in 8819cfe
As I walk through the changes in v5.1.2...v5.2.0, I don't see any particular changes that we need to add it as a base requirement and it adds additional 79Mb when building
Dockerfile. After investigating, it seems to be added in #1154 to fix the CLI problem. Sincepythainlpis mostly use as a library (import) not as much as CLI. Should we add additional extra (pythainlp[cli]) instead to cope with this?