Skip to content

Unnecessary base dependencies? #1184

Description

@what-in-the-nim

I notice that there are additional base requirements added when bumping from 5.1.2 to 5.2.0

The PYYAML, PANDAS and NUMPY

pythainlp/setup.py

Lines 45 to 52 in 8819cfe

requirements = [
"backports.zoneinfo; python_version<'3.9'",
"requests>=2.31",
PYYAML,
PANDAS,
NUMPY,
"tzdata; sys_platform == 'win32'",
]

As I walk through the changes in v5.1.2...v5.2.0, I don't see any particular changes that we need to add it as a base requirement and it adds additional 79Mb when building Dockerfile. After investigating, it seems to be added in #1154 to fix the CLI problem. Since pythainlp is mostly use as a library (import) not as much as CLI. Should we add additional extra (pythainlp[cli]) instead to cope with this?

Metadata

Metadata

Labels

dependenciesPull requests that update a dependency file

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions