-
-
Notifications
You must be signed in to change notification settings - Fork 301
Move tltk tests from noauto to extra tier #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
10d940b
f9f569e
2104d18
b0e74d6
df973e8
d53b389
440910e
3a981fe
3f9487c
8a6112b
34e40a0
c5f7a5a
368ef63
9e1146c
9998c3b
cd12517
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -6,6 +6,7 @@ | |||||||||
| from os import path | ||||||||||
|
|
||||||||||
| from pythainlp.tag import ( | ||||||||||
| NER, | ||||||||||
|
bact marked this conversation as resolved.
|
||||||||||
| PerceptronTagger, | ||||||||||
| perceptron, | ||||||||||
| pos_tag, | ||||||||||
|
|
@@ -88,6 +89,11 @@ def test_pos_tag(self): | |||||||||
| ], | ||||||||||
| ) | ||||||||||
|
|
||||||||||
| def test_NER_error_handling(self): | ||||||||||
| # Test error handling for invalid engine/corpus combination | ||||||||||
| with self.assertRaises(ValueError): | ||||||||||
| NER(engine="thainer", corpus="cat") | ||||||||||
|
bact marked this conversation as resolved.
|
||||||||||
|
|
||||||||||
|
|
||||||||||
|
Comment on lines
+92
to
97
|
||||||||||
| def test_NER_error_handling(self): | |
| # Test error handling for invalid engine/corpus combination | |
| with self.assertRaises(ValueError): | |
| NER(engine="thainer", corpus="cat") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of Python 3.14 classifier is premature. Python 3.14 is scheduled for release in October 2026, but it's currently February 2026. Adding this classifier before the Python version is officially released could cause issues with package distribution platforms and tools that validate classifiers. This change also appears unrelated to the stated purpose of the PR (moving tltk tests from noauto to extra tier). Consider removing this classifier until Python 3.14 is actually released.