Skip to content

Remove flake8 from dev dependency #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bact merged 2 commits into from
Feb 2, 2026
Merged

Remove flake8 from dev dependency #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faf84c3
Remove flake8 dependency
bact Feb 2, 2026
f6762f4
Update unittest.yml
bact Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ clean-test: ## remove test and coverage artifacts
rm -f .coverage
rm -fr htmlcov/

lint: ## check style with flake8
flake8 pythainlp tests
lint: ## check style
ruff check pythainlp tests notebooks

test: ## run tests quickly with the default Python
python -m unittest discover
Expand Down
28 changes: 13 additions & 15 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ dev = [
"build>=1.0.0",
"bump-my-version>=1.2.6",
"coverage>=7.10.7",
"flake8>=7.3.0",
"mypy>=1.19.1",
"ruff>=0.14.14",
"tox>=4.30.3",
]
Expand Down Expand Up @@ -345,23 +345,21 @@ select = [
extend-ignore = ["E402", "E501", "E722", "S101", "S202", "S301", "S310"]

[tool.tox]
envlist = ["py39", "py310", "py311", "py312", "py313", "py314", "py3", "pypy3", "flake8"]
env_list = ["py39", "py310", "py311", "py312", "py313", "py314", "pypy310", "pypy311", "ruff"]
skip_missing_interpreters = true

[tool.tox.testenv]
setenv = { PYTHONPATH = "{toxinidir}:{toxinidir}/pythainlp" }
changedir = "tests"
commands = ["discover"]
deps = ["discover"]
[tool.tox.env_run_base]
commands = [["python", "-m", "unittest", "tests.core", "tests.compact"]]
extras = ["compact"]

[tool.tox.envs.pypy3]
[tool.tox.env.pypy310]
basepython = "pypy3.10"
setenv = { PYTHONPATH = "{toxinidir}:{toxinidir}/pythainlp" }
changedir = "tests"
commands = ["discover"]
deps = ["discover"]

[tool.tox.envs.flake8]
[tool.tox.env.pypy311]
basepython = "pypy3.11"

[tool.tox.env.ruff]
basepython = "python"
deps = ["flake8"]
commands = ["flake8 pythainlp"]
deps = ["ruff"]
commands = [["ruff", "check", "pythainlp"], ["ruff", "format", "--check", "pythainlp"]]
skip_install = true
Loading