Add type hints to foundation submodules (tools, cli, corpus) - #1262
Merged
Conversation
Co-authored-by: bact <128572+bact@users.noreply.github.com>
Co-authored-by: bact <128572+bact@users.noreply.github.com>
Co-authored-by: bact <128572+bact@users.noreply.github.com>
…prove variable naming Co-authored-by: bact <128572+bact@users.noreply.github.com>
|
Copilot
AI
changed the title
[WIP] Add type hints to foundation submodules
Add type hints to foundation submodules (tools, cli, corpus)
Feb 3, 2026
bact
approved these changes
Feb 3, 2026
bact
marked this pull request as ready for review
February 3, 2026 06:01
This was referenced Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What do these changes do
Adds comprehensive type hints to 3 of 4 foundation submodules per stage 1 goal. Establishes mypy configuration and type checking infrastructure for the codebase.
Completed modules (23 files):
pythainlp.tools- 4 files, passes mypy strictpythainlp.cli- 7 files, passes mypy strictpythainlp.corpus- 12 files, all exported functions typedRemaining:
pythainlp.tokenize(24 files, 3360 lines) - deferred due to complexityInfrastructure:
pyproject.tomlWhat was wrong
Foundation submodules lacked type hints, preventing:
How this fixes it
Type hint additions:
Patterns applied:
TYPE_CHECKING usage:
Standards enforced:
Your checklist for this pull request
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.