Skip to content

Fix lazy import bugs and Python 3.9 type hint compatibility #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bact merged 18 commits into from
Feb 4, 2026
Merged

Fix lazy import bugs and Python 3.9 type hint compatibility #1274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6c457d4
Initial plan
Copilot Feb 4, 2026
2f5fd31
Initial type annotation progress check
Copilot Feb 4, 2026
ebc942e
Add type hints to module-level variables in multiple modules
Copilot Feb 4, 2026
b9f73da
Add type hints to more module-level variables
Copilot Feb 4, 2026
f417160
Add type hints to remaining small module variables
Copilot Feb 4, 2026
c4aa70d
Merge branch 'dev' into copilot/add-type-annotations-coverage
bact Feb 4, 2026
3ef033e
Fix problematic top-level imports of optional dependencies
Copilot Feb 4, 2026
146f6e4
Fix additional torch import issues in chat and generate modules
Copilot Feb 4, 2026
c56a5db
Fix remaining torch import in parse/ud_goeswith.py
Copilot Feb 4, 2026
7cc4925
Add type annotations to module variables and fix optional dependency …
Copilot Feb 4, 2026
0fe50ca
Fix Python 3.9 incompatible | union syntax in type hints
Copilot Feb 4, 2026
d7f8503
Fix missing numpy imports in w2p.py _encode and _predict methods
Copilot Feb 4, 2026
8cf7523
Plan: Continue adding variable type hints to reach 100% coverage
Copilot Feb 4, 2026
b11087c
Add type hints to module variables in corpus, generate, spell, phayat…
Copilot Feb 4, 2026
7467d93
Plan: Continue type annotations with copilot instructions noted
Copilot Feb 4, 2026
686c9d9
Add type hint to _WSC variable in words_spelling_correction.py
Copilot Feb 4, 2026
8ccc178
Add Union type to imports in core.py
bact Feb 4, 2026
1e53fb2
Remove unused import of Any from typing
bact Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions build_tools/analysis/output/class_variables_no_hints.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Variable Name,Submodule,Parent Class,Scope,File,Line
pythainlp.util.trie.Node.__slots__,util,Node,public,/home/runner/work/pythainlp/pythainlp/pythainlp/util/trie.py,53
2 changes: 1 addition & 1 deletion build_tools/analysis/output/functions_incomplete_hints.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Function Name,Submodule,Scope,Priority,Params Hinted,Has Return,References,Test Suite,File,Line
Function Name,Submodule,Scope,Priority,Params Hinted,Has Return,References,Test Suite,Decorators,File,Line
2 changes: 1 addition & 1 deletion build_tools/analysis/output/functions_no_hints.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Function Name,Submodule,Scope,Priority,References,Test Suite,File,Line
Function Name,Submodule,Scope,Priority,References,Test Suite,Decorators,File,Line
210 changes: 210 additions & 0 deletions build_tools/analysis/output/instance_variables_no_hints.csv
View file
Open in desktop

Large diffs are not rendered by default.

228 changes: 228 additions & 0 deletions build_tools/analysis/output/module_variables_no_hints.csv
View file
Open in desktop

Large diffs are not rendered by default.

56 changes: 28 additions & 28 deletions build_tools/analysis/output/submodule_summary.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
Submodule,Total,Complete,Incomplete,None,% Complete,Mypy Errors
__main__,1,1,0,0,100.00%,0
ancient,2,2,0,0,100.00%,1
augment,29,29,0,0,100.00%,1
benchmarks,8,8,0,0,100.00%,1
chat,4,4,0,0,100.00%,1
classify,5,5,0,0,100.00%,1
cli,21,21,0,0,100.00%,1
coref,5,5,0,0,100.00%,1
corpus,70,70,0,0,100.00%,1
el,5,5,0,0,100.00%,1
generate,15,15,0,0,100.00%,1
khavee,9,9,0,0,100.00%,1
lm,2,2,0,0,100.00%,1
morpheme,2,2,0,0,100.00%,1
parse,9,9,0,0,100.00%,1
phayathaibert,19,19,0,0,100.00%,1
soundex,27,27,0,0,100.00%,1
spell,43,43,0,0,100.00%,1
summarize,17,17,0,0,100.00%,1
tag,68,68,0,0,100.00%,1
tokenize,73,73,0,0,100.00%,1
ancient,2,2,0,0,100.00%,26
augment,29,29,0,0,100.00%,33
benchmarks,8,8,0,0,100.00%,26
chat,4,4,0,0,100.00%,28
classify,5,5,0,0,100.00%,26
cli,21,21,0,0,100.00%,28
coref,5,5,0,0,100.00%,26
corpus,70,70,0,0,100.00%,26
el,5,5,0,0,100.00%,26
generate,15,15,0,0,100.00%,31
khavee,9,9,0,0,100.00%,26
lm,2,2,0,0,100.00%,26
morpheme,2,2,0,0,100.00%,26
parse,9,9,0,0,100.00%,28
phayathaibert,19,19,0,0,100.00%,26
soundex,27,27,0,0,100.00%,26
spell,43,43,0,0,100.00%,26
summarize,17,17,0,0,100.00%,31
tag,73,73,0,0,100.00%,28
tokenize,73,73,0,0,100.00%,26
tokenizeicu,3,3,0,0,100.00%,0
tools,9,9,0,0,100.00%,1
translate,44,44,0,0,100.00%,1
transliterate,75,75,0,0,100.00%,1
tools,9,9,0,0,100.00%,26
translate,44,44,0,0,100.00%,33
transliterate,75,75,0,0,100.00%,27
transliterateicu,1,1,0,0,100.00%,0
ulmfit,25,25,0,0,100.00%,1
util,109,109,0,0,100.00%,1
wangchanberta,9,9,0,0,100.00%,1
word_vector,7,7,0,0,100.00%,1
wsd,4,4,0,0,100.00%,1
ulmfit,25,25,0,0,100.00%,30
util,109,109,0,0,100.00%,26
wangchanberta,9,9,0,0,100.00%,26
word_vector,7,7,0,0,100.00%,33
wsd,4,4,0,0,100.00%,28
1 change: 1 addition & 0 deletions build_tools/analysis/output/type_aliases.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Type Alias Name,Submodule,Scope,File,Line
Loading
Loading