Skip to content

Remove pickle from pythainlp/generate/thai2fit.py - #1325

Merged
bact merged 4 commits into
devfrom
remove-pickle
Mar 13, 2026
Merged

Remove pickle from pythainlp/generate/thai2fit.py#1325
bact merged 4 commits into
devfrom
remove-pickle

Conversation

@wannaphong

@wannaphong wannaphong commented Mar 13, 2026

Copy link
Copy Markdown
Member

Remove pickle from pythainlp/generate/thai2fit.py

Partly fix #1326

Your checklist for this pull request

  • Passed code styles and structures
  • Passed code linting checks and unit test

@bact bact added the refactoring a technical improvement which does not add any new features or change existing features. label Mar 13, 2026
Comment thread pythainlp/generate/thai2fit.py Outdated
Comment thread pythainlp/generate/thai2fit.py Outdated
wannaphong and others added 2 commits March 14, 2026 00:14
Co-authored-by: Arthit Suriyawongkul <arthit@gmail.com>
Co-authored-by: Arthit Suriyawongkul <arthit@gmail.com>
@wannaphong
wannaphong requested a review from bact March 13, 2026 17:15
@sonarqubecloud

Copy link
Copy Markdown

@wannaphong

Copy link
Copy Markdown
Member Author

@bact I think we can release v5.3.1 to remove pickle.

@bact bact left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@bact bact added this to the 5.3.1 milestone Mar 13, 2026
@bact bact added the security label Mar 13, 2026
@bact
bact merged commit a5432cc into dev Mar 13, 2026
27 checks passed
@bact
bact deleted the remove-pickle branch March 13, 2026 18:48
@bact

bact commented Mar 13, 2026

Copy link
Copy Markdown
Member

@bact I think we can release v5.3.1 to remove pickle.

@wannaphong agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring a technical improvement which does not add any new features or change existing features. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the use of pickle for model files

2 participants