Skip to content

Add sponsors - #1350

Merged
wannaphong merged 11 commits into
devfrom
add-sponsors
Mar 21, 2026
Merged

Add sponsors#1350
wannaphong merged 11 commits into
devfrom
add-sponsors

Conversation

@wannaphong

Copy link
Copy Markdown
Member

Add sponsors details

@wannaphong
wannaphong marked this pull request as ready for review March 20, 2026 16:59
Comment thread README.md Outdated
Comment on lines 265 to 266

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove these logos then? Having logos here can be confusing if these are affiliations.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't sure about Acknowledgements. I think SPONSORS.md is clear enough that pythainlp is not under any affiliations but README.md is show Acknowledgements for affiliations. How do you think?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I clear up logos. It will make clear README.md and reduce confusing.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Keep the history of support in acknowledgements. We have to thank all the support in the past. Just remove the outdated logos.

Just like the way you did. Thank you.

Removed logo images from the README.
@sonarqubecloud

Copy link
Copy Markdown

@wannaphong
wannaphong merged commit 715cc06 into dev Mar 21, 2026
16 checks passed
@wannaphong

Copy link
Copy Markdown
Member Author
ภาพ

It's working. Follow https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/displaying-a-sponsor-button-in-your-repository say "You can add one organization and up to four sponsored developers in GitHub Sponsors".

@bact
bact deleted the add-sponsors branch March 24, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants