Skip to content

Add type ignore comments for type tests - #1362

Merged
bact merged 3 commits into
PyThaiNLP:devfrom
bact:fix-type-tests
Mar 23, 2026
Merged

Add type ignore comments for type tests#1362
bact merged 3 commits into
PyThaiNLP:devfrom
bact:fix-type-tests

Conversation

@bact

@bact bact commented Mar 23, 2026

Copy link
Copy Markdown
Member

What do these changes do

Add # type: ignore to tests that intentionally testing wrong types

  • Passed code styles and structures
  • Passed code linting checks and unit test

@bact bact added this to the 5.3.3 milestone Mar 23, 2026
@bact bact added refactoring a technical improvement which does not add any new features or change existing features. tests Unit test, code coverage, test case labels Mar 23, 2026
@bact bact added this to PyThaiNLP Mar 23, 2026
@coveralls

coveralls commented Mar 23, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 66.557% (+0.02%) from 66.536%
when pulling 5d0282b on bact:fix-type-tests
into 9c7bf41 on PyThaiNLP:dev.

@sonarqubecloud

Copy link
Copy Markdown

@bact
bact merged commit e9a80ad into PyThaiNLP:dev Mar 23, 2026
27 checks passed
@bact
bact deleted the fix-type-tests branch March 23, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring a technical improvement which does not add any new features or change existing features. tests Unit test, code coverage, test case

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants