Skip to content

mypy strict = true - #1364

Merged
bact merged 3 commits into
PyThaiNLP:devfrom
bact:rm-mypy-overrides
Mar 24, 2026
Merged

mypy strict = true#1364
bact merged 3 commits into
PyThaiNLP:devfrom
bact:rm-mypy-overrides

Conversation

@bact

@bact bact commented Mar 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Passed code styles and structures
  • Passed code linting checks and unit test

@bact bact added this to the 5.3.3 milestone Mar 24, 2026
@bact bact added this to PyThaiNLP Mar 24, 2026
@bact bact added the tests Unit test, code coverage, test case label Mar 24, 2026
@coveralls

coveralls commented Mar 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Status

coverage: 66.574%. remained the same
when pulling 7f7d706 on bact:rm-mypy-overrides
into 82d4302 on PyThaiNLP:dev.

@bact bact changed the title Remove mypy overrides mypy strict = true Mar 24, 2026
@bact bact moved this to In progress in PyThaiNLP Mar 24, 2026
@bact bact added the refactoring a technical improvement which does not add any new features or change existing features. label Mar 24, 2026
@sonarqubecloud

sonarqubecloud Bot commented Mar 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
80.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bact
bact merged commit 1110c48 into PyThaiNLP:dev Mar 24, 2026
26 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in PyThaiNLP Mar 24, 2026
@bact
bact deleted the rm-mypy-overrides branch March 24, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

refactoring a technical improvement which does not add any new features or change existing features. tests Unit test, code coverage, test case

Projects

PyThaiNLP
Status: Done

Milestone

5.3.3

Development

Successfully merging this pull request may close these issues.

2 participants

@bact @coveralls