Skip to content

fix: use full version string in _check_version for <= and < operators #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bact merged 4 commits into from
Mar 31, 2026
+18 −2
Merged

fix: use full version string in _check_version for <= and < operators #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5ff0ee
fix: use full version string in _check_version for <= and < operators
phoneee Mar 29, 2026
28d9117
Reorder import statements in test_corpus.py
bact Mar 31, 2026
d297e45
Apply suggestion from @bact
bact Mar 31, 2026
2287acf
Add version checks for minimum version requirements
bact Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pythainlp/corpus/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,10 +632,10 @@ def _check_version(cause: str) -> bool:
check = _version2int(temp_parts[0]) < v < _version2int(temp_parts[1])
elif cause.startswith("<="):
temp = cause.replace("<=", "")
check = v <= _version2int(temp[0])
check = v <= _version2int(temp)
elif cause.startswith("<"):
temp = cause.replace("<", "")
check = v < _version2int(temp[0])
check = v < _version2int(temp)

return check

Expand Down
16 changes: 16 additions & 0 deletions tests/core/test_corpus.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
tnc,
ttc,
)
from pythainlp.corpus.core import _check_version, _version2int
from pythainlp.corpus.util import revise_newmm_default_wordset


Expand Down Expand Up @@ -621,3 +622,18 @@ def test_thai_synonyms_loads_valid_rows(self):
self.assertEqual(
result["synonym"], [["cat", "kitty"], ["dog"]]
)

def test_check_version(self):
# Reproduce: _check_version with <= and < used temp[0] which
# only gets the first character of the version string instead
# of the full version, causing incorrect comparisons.
self.assertTrue(_check_version("*"))
self.assertTrue(_check_version("<=9999.9.9"))
self.assertTrue(_check_version("<9999.9.9"))
self.assertTrue(_check_version(">=0.0.1"))
self.assertTrue(_check_version(">0.0.1"))
self.assertFalse(_check_version("<=0.0.1"))
self.assertFalse(_check_version("<0.0.1"))
# version2int consistency
self.assertNotEqual(_version2int("5.3.3"), _version2int("5"))
self.assertEqual(_version2int("2.0"), _version2int("2.0.0"))
Loading