From abde807eeea9344c34545c3e8cc9e8439df1a249 Mon Sep 17 00:00:00 2001 From: phoneee Date: Sun, 29 Mar 2026 16:42:31 +0700 Subject: [PATCH 1/3] fix: remove misleading second arg from assertTrue/assertFalse calls assertTrue(expr, True) passes True as the failure message parameter, not as the expected value. The tests passed accidentally because is_native_thai returns a truthy value. Remove the second argument so assertions properly test the return value. --- tests/core/test_morpheme.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/core/test_morpheme.py b/tests/core/test_morpheme.py index c3c5449c8..4ab43a1e8 100644 --- a/tests/core/test_morpheme.py +++ b/tests/core/test_morpheme.py @@ -27,15 +27,15 @@ def test_is_native_thai(self): self.assertFalse(is_native_thai("abc"), False) self.assertFalse(is_native_thai("ศา"), False) self.assertFalse(is_native_thai("ลักษ์"), False) - self.assertFalse(is_native_thai("มาร์ค"), False) - self.assertFalse(is_native_thai("เลข"), False) - self.assertFalse(is_native_thai("เทเวศน์"), False) - self.assertFalse(is_native_thai("เทเวศร์"), False) - self.assertTrue(is_native_thai("ตา"), True) - self.assertTrue(is_native_thai("ยา"), True) - self.assertTrue(is_native_thai("ฆ่า"), True) - self.assertTrue(is_native_thai("คน"), True) - self.assertTrue(is_native_thai("มอ"), True) - self.assertTrue(is_native_thai("กะ"), True) - self.assertTrue(is_native_thai("กระ"), True) - self.assertTrue(is_native_thai("ประท้วง"), True) + self.assertFalse(is_native_thai("มาร์ค")) + self.assertFalse(is_native_thai("เลข")) + self.assertFalse(is_native_thai("เทเวศน์")) + self.assertFalse(is_native_thai("เทเวศร์")) + self.assertTrue(is_native_thai("ตา")) + self.assertTrue(is_native_thai("ยา")) + self.assertTrue(is_native_thai("ฆ่า")) + self.assertTrue(is_native_thai("คน")) + self.assertTrue(is_native_thai("มอ")) + self.assertTrue(is_native_thai("กะ")) + self.assertTrue(is_native_thai("กระ")) + self.assertTrue(is_native_thai("ประท้วง")) From 14c8a1d23b4523e8a3c36802304453cfb07eec4e Mon Sep 17 00:00:00 2001 From: Arthit Suriyawongkul Date: Mon, 30 Mar 2026 23:33:48 +0100 Subject: [PATCH 2/3] Remove second args of assertFalse/assertTrue --- tests/core/test_morpheme.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/core/test_morpheme.py b/tests/core/test_morpheme.py index 4ab43a1e8..ba150dc90 100644 --- a/tests/core/test_morpheme.py +++ b/tests/core/test_morpheme.py @@ -26,7 +26,12 @@ def test_is_native_thai(self): self.assertFalse(is_native_thai("116"), False) self.assertFalse(is_native_thai("abc"), False) self.assertFalse(is_native_thai("ศา"), False) - self.assertFalse(is_native_thai("ลักษ์"), False) +self.assertFalse(is_native_thai(None)) # type: ignore[arg-type] +self.assertFalse(is_native_thai("")) +self.assertFalse(is_native_thai("116")) +self.assertFalse(is_native_thai("abc")) +self.assertFalse(is_native_thai("ศา")) +self.assertFalse(is_native_thai("ลักษ์")) self.assertFalse(is_native_thai("มาร์ค")) self.assertFalse(is_native_thai("เลข")) self.assertFalse(is_native_thai("เทเวศน์")) From 34ab7391bedf0cbfc99a5e375b068cdd890b1491 Mon Sep 17 00:00:00 2001 From: Arthit Suriyawongkul Date: Mon, 30 Mar 2026 23:34:50 +0100 Subject: [PATCH 3/3] Refactor test cases for is_native_thai function --- tests/core/test_morpheme.py | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/tests/core/test_morpheme.py b/tests/core/test_morpheme.py index ba150dc90..9e81b2b28 100644 --- a/tests/core/test_morpheme.py +++ b/tests/core/test_morpheme.py @@ -21,17 +21,12 @@ def test_nighit(self): nighit("สํ", "มาร") # consonant ม is not in any supported group def test_is_native_thai(self): - self.assertFalse(is_native_thai(None), False) # type: ignore[arg-type] - self.assertFalse(is_native_thai(""), False) - self.assertFalse(is_native_thai("116"), False) - self.assertFalse(is_native_thai("abc"), False) - self.assertFalse(is_native_thai("ศา"), False) -self.assertFalse(is_native_thai(None)) # type: ignore[arg-type] -self.assertFalse(is_native_thai("")) -self.assertFalse(is_native_thai("116")) -self.assertFalse(is_native_thai("abc")) -self.assertFalse(is_native_thai("ศา")) -self.assertFalse(is_native_thai("ลักษ์")) + self.assertFalse(is_native_thai(None)) # type: ignore[arg-type] + self.assertFalse(is_native_thai("")) + self.assertFalse(is_native_thai("116")) + self.assertFalse(is_native_thai("abc")) + self.assertFalse(is_native_thai("ศา")) + self.assertFalse(is_native_thai("ลักษ์")) self.assertFalse(is_native_thai("มาร์ค")) self.assertFalse(is_native_thai("เลข")) self.assertFalse(is_native_thai("เทเวศน์"))