Skip to content

fix: remove misleading second arg from assertTrue/assertFalse calls #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bact merged 3 commits into from
Mar 31, 2026
+18 −18
Merged

fix: remove misleading second arg from assertTrue/assertFalse calls #1381

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abde807
fix: remove misleading second arg from assertTrue/assertFalse calls
phoneee Mar 29, 2026
14c8a1d
Remove second args of assertFalse/assertTrue
bact Mar 30, 2026
34ab739
Refactor test cases for is_native_thai function
bact Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions tests/core/test_morpheme.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,21 +21,21 @@ def test_nighit(self):
nighit("สํ", "มาร") # consonant ม is not in any supported group

def test_is_native_thai(self):
self.assertFalse(is_native_thai(None), False) # type: ignore[arg-type]
self.assertFalse(is_native_thai(""), False)
self.assertFalse(is_native_thai("116"), False)
self.assertFalse(is_native_thai("abc"), False)
self.assertFalse(is_native_thai("ศา"), False)
self.assertFalse(is_native_thai("ลักษ์"), False)
self.assertFalse(is_native_thai("มาร์ค"), False)
self.assertFalse(is_native_thai("เลข"), False)
self.assertFalse(is_native_thai("เทเวศน์"), False)
self.assertFalse(is_native_thai("เทเวศร์"), False)
self.assertTrue(is_native_thai("ตา"), True)
self.assertTrue(is_native_thai("ยา"), True)
self.assertTrue(is_native_thai("ฆ่า"), True)
self.assertTrue(is_native_thai("คน"), True)
self.assertTrue(is_native_thai("มอ"), True)
self.assertTrue(is_native_thai("กะ"), True)
self.assertTrue(is_native_thai("กระ"), True)
self.assertTrue(is_native_thai("ประท้วง"), True)
self.assertFalse(is_native_thai(None)) # type: ignore[arg-type]
self.assertFalse(is_native_thai(""))
self.assertFalse(is_native_thai("116"))
self.assertFalse(is_native_thai("abc"))
self.assertFalse(is_native_thai("ศา"))
self.assertFalse(is_native_thai("ลักษ์"))
self.assertFalse(is_native_thai("มาร์ค"))
self.assertFalse(is_native_thai("เลข"))
self.assertFalse(is_native_thai("เทเวศน์"))
self.assertFalse(is_native_thai("เทเวศร์"))
self.assertTrue(is_native_thai("ตา"))
Comment thread
bact marked this conversation as resolved.
self.assertTrue(is_native_thai("ยา"))
self.assertTrue(is_native_thai("ฆ่า"))
self.assertTrue(is_native_thai("คน"))
self.assertTrue(is_native_thai("มอ"))
self.assertTrue(is_native_thai("กะ"))
self.assertTrue(is_native_thai("กระ"))
self.assertTrue(is_native_thai("ประท้วง"))
Loading