fix: guard han_solo list_cut[-1] and narrow longest.py exception catch - #1382
Merged
Conversation
han_solo: if CRF predicts "0" for first char, list_cut is empty and list_cut[-1] raises IndexError. Add fallback to append when empty. longest: except BaseException catches KeyboardInterrupt and SystemExit. Narrow to except IndexError which is the only expected exception.
Member
|
Btw, have to put type annotation for list_cut to pass mypy |
bact
reviewed
Mar 30, 2026
|
bact
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do
Guard
list_cut[-1]in han_solo when list is emptyNarrow
except BaseExceptiontoexcept IndexErrorin longestPassed code styles and structures
Passed code linting checks and unit test