Skip to content

Fix the logic of check_sara, check_marttra, is_sumpus, handle_karun_sound_silence #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Warit-Yuv wants to merge 44 commits into
base: main
Choose a base branch
from
+1,482 −517
Open

Fix the logic of check_sara, check_marttra, is_sumpus, handle_karun_sound_silence #1453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
b67a753
Edit the incorrect logic in check_marttra for handling character ล in…
Warit-Yuv Jul 19, 2026
17c8eec
Fix the logic error in is_sumpus function
Warit-Yuv Jul 19, 2026
9c48e22
Fix check_sara function edge case of ฤ which can have 3 sounds - เรอ,…
Warit-Yuv Jul 19, 2026
9bcc977
Fix the previous typo in ฤ ฦ check_sara function
Warit-Yuv Jul 19, 2026
75f498d
Refactor conditions for 'ฤ' sound handling
Warit-Yuv Jul 19, 2026
747c153
Improve handle_karun_sound_silence handling and vowel merging (เอ เอ)
Warit-Yuv Jul 19, 2026
48a191c
Fix the original typo in check_sara function.
Warit-Yuv Jul 19, 2026
4d2ee03
Update normalization logic for is_sumpus function
Warit-Yuv Jul 19, 2026
8afcfe5
Fix indentation. Remove Trailing whitespace in line 693.
Warit-Yuv Jul 19, 2026
139b0de
Add สระประสม Transformed vowels classifier to check_sara and Fix คำโด…
Warit-Yuv Jul 19, 2026
b3cc0d6
Rewrite _has_true_final_yl function
Warit-Yuv Jul 20, 2026
6cb76a5
Refactor final consonant checks in KhaveeVerifier
Warit-Yuv Jul 20, 2026
c88e5e3
Refactor _has_true_final_yl method for clarity
Warit-Yuv Jul 20, 2026
c0191c2
Potential fix for pull request finding
Warit-Yuv Jul 21, 2026
b75e409
Fix `check_sara` ฤ evaluation in the word with silent Karun.
Warit-Yuv Jul 21, 2026
61d5f9e
Enhance handling of silent vowels and fix some more edge cases in `ch…
Warit-Yuv Jul 21, 2026
03d123b
Add many more test case and fix the category of the word ไทย ไกล ใกล้
Warit-Yuv Jul 21, 2026
9085b57
Fix the นิกหิต -ํ and รากยาว "ๅ" ฤ ฤๅ logic
Warit-Yuv Jul 21, 2026
bef0c44
Fix the typo in the testcase kv.check_sara("ตรี"), "อี"
Warit-Yuv Jul 22, 2026
a8ffb00
Fix typo in test case for check_sara function
Warit-Yuv Jul 22, 2026
114c238
Enhance check_sara and _is_true_final methods for better vowel handli…
Warit-Yuv Jul 23, 2026
f47cf01
fixing -ึ in check_mattra and format the code
Warit-Yuv Jul 23, 2026
f0586be
fix missclassified when ฤฦ in front of word and fix สระอำ missclassif…
Warit-Yuv Jul 23, 2026
da79cf5
Fix test case so ขำ จำ (อำ) is correctly classified as แม่ก กา
Warit-Yuv Jul 23, 2026
afb03a2
Add more test cases to is_sumpus for better coverage and accuracy wh…
Warit-Yuv Jul 23, 2026
34abf2e
Correct the parsing of original_word into _is_true_final. As true fin…
Warit-Yuv Jul 23, 2026
ea5614c
Refactor comments in test cases for clarity and consistency
Warit-Yuv Jul 23, 2026
53c82a0
Format the ocde to remove trailing white space.
Warit-Yuv Jul 23, 2026
c64738f
Enhance test case documentation for KhaveeVerifier methods with detai…
Warit-Yuv Jul 23, 2026
56b5602
Add 1 blank line before each of class docstring (D203 PEP 257 convent…
Warit-Yuv Jul 23, 2026
f780e36
fix the รร loop logic in `check_sara`
Warit-Yuv Jul 23, 2026
c29c507
Enhance documentation for check_sara, check_marttra, and is_sumpus me…
Warit-Yuv Jul 23, 2026
078e0d4
Refactor tests for check_karu_lahu method: streamline test cases for …
Warit-Yuv Jul 23, 2026
738eef7
Refactor `_is_true_final` to reduce complexity.
Warit-Yuv Jul 23, 2026
f423d9c
Fix rhyme error messages in KhaveeVerifier: fix f string in error.app…
Warit-Yuv Jul 23, 2026
5f49781
Baked in VALID_CONSONANTS as frozenset(thai_consonants + "ฤฦ") for op…
Warit-Yuv Jul 23, 2026
e85c13e
Rewrite `check_klon`, `test_khavee.py`
Warit-Yuv Jul 23, 2026
54ed2b7
Refactor check_klon tests: move to new test_khavee_extended.py and up…
Warit-Yuv Jul 23, 2026
d24f9d3
Fix test_check_klon assertion to expect string instead of list
Warit-Yuv Jul 23, 2026
3a46dde
perf(khavee): optimize character lookups and simplify klon output
Warit-Yuv Jul 28, 2026
b5962d8
refactor(khavee): harden edge cases, improve marttra cluster logic
Warit-Yuv Jul 28, 2026
b3e9378
perf(khavee): move repeated sets to class constants, simplify char ch…
Warit-Yuv Jul 28, 2026
ecb8a74
chore(khavee): remove unused import re, trailing whitespace
Warit-Yuv Jul 28, 2026
7d2769c
fix(khavee): remove redundant marttra check, fix assertEqual arg order
Warit-Yuv Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading