fix: ♻️ Handle exceptions during message edits in Paginator and BaseView timeouts (#3019)

* fix:  ♻️ Handle discord.HTTPException during message edits in Paginator and BaseView

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix:  ♻️ Update changelog to reflect changes in BaseView and Paginator timeout behavior

* Update discord/ext/pages/pagination.py

Co-authored-by: Paillat <jeremiecotti@ik.me>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

* fix: reorder timeout error handling in changelog

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix: format changelog for better readability

* style(pre-commit): auto fixes from pre-commit.com hooks

* chore: update changelog with new features, changes, and fixes for version 2.7.0

* style(pre-commit): auto fixes from pre-commit.com hooks

* chore: update changelog with new features, changes, and fixes for Components V2 and other improvements

* fix: improve error handling and clean up type annotations in Paginator and BaseView

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix: improve message handling and type hint formatting in BaseView and ViewStore

* style(pre-commit): auto fixes from pre-commit.com hooks

* fix: replace discord error references with local imports in BaseView

* style(pre-commit): auto fixes from pre-commit.com hooks

* Apply suggestion from @Paillat-dev

Signed-off-by: Paillat <jeremiecotti@ik.me>

* style(pre-commit): auto fixes from pre-commit.com hooks

* Update CHANGELOG.md

Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>
Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

---------

Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>
Signed-off-by: Paillat <jeremiecotti@ik.me>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Paillat <jeremiecotti@ik.me>
Co-authored-by: Paillat <paillat@pycord.dev>
Co-authored-by: JustaSqu1d <89910983+JustaSqu1d@users.noreply.github.com>

Author: 4 people

CHANGELOG.md

@@ -26,6 +26,8 @@ These changes are available on the `master` branch, but have not yet been releas
 
 ### Fixed
 
+- Fixed an issue where views raised unnecessary errors on timeout.
+  ([#3019](https://github.com/Pycord-Development/pycord/pull/3019))
 - Fixed `RawMessageUpdateEvent.cached_message` being always `None` even when the message
   was cached. ([#3038](https://github.com/Pycord-Development/pycord/pull/3038))
 - Fixed an issue with downloading animated emojis which were originally uploaded as WebP

discord/ext/pages/pagination.py

@@ -24,6 +24,7 @@
 
 from __future__ import annotations
 
+import contextlib
 from typing import List
 
 import discord
@@ -604,11 +605,12 @@ async def on_timeout(self) -> None:
             page = self.pages[self.current_page]
             page = self.get_page_content(page)
             files = page.update_files()
-            await self.message.edit(
-                view=self,
-                files=files or [],
-                attachments=[],
-            )
+            with contextlib.suppress(discord.NotFound, discord.Forbidden):
+                await self.message.edit(
+                    view=self,
+                    files=files or [],
+                    attachments=[],
+                )
 
     async def disable(
         self,

discord/ui/view.py

@@ -26,6 +26,7 @@
 from __future__ import annotations
 
 import asyncio
+import contextlib
 import os
 import sys
 import time
@@ -56,7 +57,7 @@
 from ..components import Thumbnail as ThumbnailComponent
 from ..components import _component_factory
 from ..enums import ChannelType
-from ..utils import find
+from ..errors import Forbidden, NotFound
 from .core import ItemInterface
 from .item import ItemCallbackType, ViewItem
 
@@ -97,7 +98,6 @@ def _walk_all_components_v2(components: list[Component]) -> Iterator[Component]:
 
 
 def _component_to_item(component: Component) -> ViewItem[V]:
-
     if isinstance(component, ButtonComponent):
         from .button import Button
 
@@ -321,9 +321,10 @@ async def on_timeout(self) -> None:
                 message = self.message
 
             if message:
-                m = await message.edit(view=self)
-                if m:
-                    self._message = m
+                with contextlib.suppress(NotFound, Forbidden):
+                    m = await message.edit(view=self)
+                    if m:
+                        self._message = m
 
     async def on_check_failure(self, interaction: Interaction) -> None:
         """|coro|
@@ -692,7 +693,7 @@ def add_item(self, item: ViewItem[V]) -> Self:
 
         if item._underlying.is_v2():
             raise ValueError(
-                f"cannot use V2 components in View. Use DesignerView instead."
+                "cannot use V2 components in View. Use DesignerView instead."
             )
         if isinstance(item._underlying, ActionRowComponent):
             for i in item.children:
@@ -729,7 +730,9 @@ def clear_items(self) -> None:
     def refresh(self, components: list[Component]):
         # This is pretty hacky at the moment
         old_state: dict[tuple[int, str], ViewItem[V]] = {
-            (item.type.value, item.custom_id): item for item in self.children if item.is_dispatchable()  # type: ignore
+            (item.type.value, item.custom_id): item
+            for item in self.children
+            if item.is_dispatchable()  # type: ignore
         }
         children: list[ViewItem[V]] = [
             item for item in self.children if not item.is_dispatchable()
@@ -889,7 +892,7 @@ def add_item(self, item: ViewItem[V]) -> Self:
 
         if isinstance(item._underlying, (SelectComponent, ButtonComponent)):
             raise ValueError(
-                f"cannot add Select or Button to DesignerView directly. Use ActionRow instead."
+                "cannot add Select or Button to DesignerView directly. Use ActionRow instead."
             )
 
         super().add_item(item)
@@ -951,7 +954,10 @@ def add_view(self, view: BaseView, message_id: int | None = None):
         view._start_listening_from_store(self)
         for item in view.walk_children():
             if item.is_storable():
-                self._views[(item.type.value, message_id, item.custom_id)] = (view, item)  # type: ignore
+                self._views[(item.type.value, message_id, item.custom_id)] = (
+                    view,
+                    item,
+                )  # type: ignore
 
         if message_id is not None:
             self._synced_message_views[message_id] = view