Refactor component limits and embed limits

- Introduced `EmbedLimits` class to define constraints for Discord embeds.
- Removed the `ComponentLimits` enum and replaced it with a `ComponentLimits` class in `core.py` to define constraints for various UI components.
- Updated all relevant UI components (Button, Checkbox, CheckboxGroup, FileUpload, InputText, MediaGallery, Modal, RadioGroup, Select, View) to use the new `ComponentLimits` class for validation.
- Removed old `ComponentLimits` enum documentation from `enums.rst` and added new documentation for the `ComponentLimits` class.
- Ensured all limits are consistently referenced across the codebase.

Author: Lumabots

discord/components.py

@@ -32,7 +32,6 @@
 from .enums import (
     ButtonStyle,
     ChannelType,
-    ComponentLimits,
     ComponentType,
     InputTextStyle,
     SelectDefaultValueType,
@@ -42,6 +41,7 @@
 from .flags import AttachmentFlags
 from .partial_emoji import PartialEmoji, _EmojiTag
 from .utils import MISSING, find, get_slots
+from .ui.core import ComponentLimits
 
 if TYPE_CHECKING:
     from . import abc
@@ -725,25 +725,25 @@ def __init__(
         emoji: str | GuildEmoji | AppEmoji | PartialEmoji | None = None,
         default: bool = False,
     ) -> None:
-        if len(label) > ComponentLimits.select_option_label_max.value:
+        if len(label) > ComponentLimits.SELECT_OPTION_LABEL_MAX:
             raise ValueError(
-                f"label must be {ComponentLimits.select_option_label_max.value} characters or fewer"
+                f"label must be {ComponentLimits.SELECT_OPTION_LABEL_MAX} characters or fewer"
             )
 
         if (
             value is not MISSING
-            and len(value) > ComponentLimits.select_option_value_max.value
+            and len(value) > ComponentLimits.SELECT_OPTION_VALUE_MAX
         ):
             raise ValueError(
-                f"value must be {ComponentLimits.select_option_value_max.value} characters or fewer"
+                f"value must be {ComponentLimits.SELECT_OPTION_VALUE_MAX} characters or fewer"
             )
 
         if (
             description is not None
-            and len(description) > ComponentLimits.select_option_description_max.value
+            and len(description) > ComponentLimits.SELECT_OPTION_DESCRIPTION_MAX
         ):
             raise ValueError(
-                f"description must be {ComponentLimits.select_option_description_max.value} characters or fewer"
+                f"description must be {ComponentLimits.SELECT_OPTION_DESCRIPTION_MAX} characters or fewer"
             )
 
         self.label = label
@@ -1540,25 +1540,25 @@ def __init__(
         description: str | None = None,
         default: bool = False,
     ) -> None:
-        if len(label) > ComponentLimits.select_option_label_max.value:
+        if len(label) > ComponentLimits.SELECT_OPTION_LABEL_MAX:
             raise ValueError(
-                f"label must be {ComponentLimits.select_option_label_max.value} characters or fewer"
+                f"label must be {ComponentLimits.SELECT_OPTION_LABEL_MAX} characters or fewer"
             )
 
         if (
             value is not MISSING
-            and len(value) > ComponentLimits.select_option_value_max.value
+            and len(value) > ComponentLimits.SELECT_OPTION_VALUE_MAX
         ):
             raise ValueError(
-                f"value must be {ComponentLimits.select_option_value_max.value} characters or fewer"
+                f"value must be {ComponentLimits.SELECT_OPTION_VALUE_MAX} characters or fewer"
             )
 
         if (
             description is not None
-            and len(description) > ComponentLimits.select_option_description_max.value
+            and len(description) > ComponentLimits.SELECT_OPTION_DESCRIPTION_MAX
         ):
             raise ValueError(
-                f"description must be {ComponentLimits.select_option_description_max.value} characters or fewer"
+                f"description must be {ComponentLimits.SELECT_OPTION_DESCRIPTION_MAX} characters or fewer"
             )
 
         self.label = label
@@ -1712,25 +1712,25 @@ def __init__(
         description: str | None = None,
         default: bool = False,
     ) -> None:
-        if len(label) > ComponentLimits.select_option_label_max.value:
+        if len(label) > ComponentLimits.SELECT_OPTION_LABEL_MAX:
             raise ValueError(
-                f"label must be {ComponentLimits.select_option_label_max.value} characters or fewer"
+                f"label must be {ComponentLimits.SELECT_OPTION_LABEL_MAX} characters or fewer"
             )
 
         if (
             value is not MISSING
-            and len(value) > ComponentLimits.select_option_value_max.value
+            and len(value) > ComponentLimits.SELECT_OPTION_VALUE_MAX
         ):
             raise ValueError(
-                f"value must be {ComponentLimits.select_option_value_max.value} characters or fewer"
+                f"value must be {ComponentLimits.SELECT_OPTION_VALUE_MAX} characters or fewer"
             )
 
         if (
             description is not None
-            and len(description) > ComponentLimits.select_option_description_max.value
+            and len(description) > ComponentLimits.SELECT_OPTION_DESCRIPTION_MAX
         ):
             raise ValueError(
-                f"description must be {ComponentLimits.select_option_description_max.value} characters or fewer"
+                f"description must be {ComponentLimits.SELECT_OPTION_DESCRIPTION_MAX} characters or fewer"
             )
 
         self.label = label

discord/embeds.py

@@ -33,6 +33,7 @@
 
 __all__ = (
     "Embed",
+    "EmbedLimits",
     "EmbedField",
     "EmbedAuthor",
     "EmbedFooter",
@@ -43,6 +44,28 @@
 
 E = TypeVar("E", bound="Embed")
 
+
+class EmbedLimits:
+    # Embed field constraints
+    FIELDS_MAX = 25
+
+    # Field title/name constraints
+    FIELD_NAME_MAX = 256
+
+    # Field value constraints
+    FIELD_VALUE_MAX = 1024
+
+    # Embed description constraints
+    DESCRIPTION_MAX = 4096
+
+    # Embed footer constraints
+    FOOTER_TEXT_MAX = 2048
+
+    # Embed author constraints
+    AUTHOR_NAME_MAX = 256
+    TITLE_MAX = 256
+    TOTAL_MAX = 6000
+
 if TYPE_CHECKING:
     from discord.types.embed import Embed as EmbedData
     from discord.types.embed import EmbedType

discord/enums.py

@@ -88,8 +88,6 @@
     "SelectDefaultValueType",
     "ApplicationEventWebhookStatus",
     "InviteTargetUsersJobStatusCode",
-    "ComponentLimits",
-    "EmbedLimits",
 )
 
 
@@ -1210,107 +1208,6 @@ class InviteTargetUsersJobStatusCode(Enum):
     failed = 3
 
 
-class ComponentLimits(Enum):
-    # View constraints
-    view_children_max = 40
-
-    # ActionRow constraints
-    action_row_children_max = 5
-
-    # Button constraints
-    button_label_max = 80
-
-    # Container constraints
-    container_children_max = -1  # No limit
-
-    # MediaGallery constraints
-    media_gallery_items_min = 1
-    media_gallery_items_max = 10
-
-    # MediaGalleryItem constraints
-    media_gallery_item_description_max = 256
-
-    # Select constraints
-    select_placeholder_max = 150
-    select_min_value_min = 0
-    select_min_value_max = 25
-    select_max_value_min = 1
-    select_max_value_max = 25
-    select_options_max = 25
-    select_default_values_max = 25
-
-    # Select option constraints
-    select_option_label_max = 100
-    select_option_value_max = 100
-    select_option_description_max = 100
-
-    # Section constraints
-    section_accessory_max = 1
-    section_children_min = 1
-    section_children_max = 3
-
-    # TextInput constraints
-    text_input_max_count = 5
-    text_input_label_max = 45
-    text_input_placeholder_max = 100
-    text_input_min_length_min = 0
-    text_input_min_length_max = 4000
-    text_input_max_length_min = 1
-    text_input_max_length_max = 4000
-    text_input_value_max = 4000
-
-    # TextDisplay constraints
-    text_display_content_max = 4000
-
-    # Thumbnail constraints
-    thumbnail_description_max = 256
-
-    # Custom ID constraints
-    custom_id_min = 1
-    custom_id_max = 100
-
-    # RadioGroup constraints
-    radio_options_max = 10
-
-    # CheckboxGroup constraints
-    checkbox_options_max = 10
-    checkbox_min_values_min = 0
-    checkbox_min_values_max = 10
-    checkbox_max_values_min = 1
-    checkbox_max_values_max = 10
-
-    # FileUpload constraints
-    file_upload_min_files = 0
-    file_upload_max_files_max = 10
-    file_upload_max_values_min = 1
-
-    # Modal constraints
-    modal_title_max = 45
-    modal_rows_max = 5
-
-
-class EmbedLimits(Enum):
-    # Embed field constraints
-    fields_max = 25
-
-    # Field title/name constraints
-    field_name_max = 256
-
-    # Field value constraints
-    field_value_max = 1024
-
-    # Embed description constraints
-    description_max = 4096
-
-    # Embed footer constraints
-    footer_text_max = 2048
-
-    # Embed author constraints
-    author_name_max = 256
-    title_max = 256
-    total_max = 6000
-
-
 T = TypeVar("T")
 
 

discord/ui/button.py

@@ -113,16 +113,16 @@ def __init__(
         self._row: int | None = None
         self._rendered_row: int | None = None
         super().__init__()
-        if label and len(str(label)) > ComponentLimits.button_label_max.value:
+        if label and len(str(label)) > ComponentLimits.BUTTON_LABEL_MAX:
             raise ValueError(
-                f"label must be {ComponentLimits.button_label_max.value} characters or fewer"
+                f"label must be {ComponentLimits.BUTTON_LABEL_MAX} characters or fewer"
             )
         if (
             custom_id is not None
-            and len(str(custom_id)) > ComponentLimits.custom_id_max.value
+            and len(str(custom_id)) > ComponentLimits.CUSTOM_ID_MAX
         ):
             raise ValueError(
-                f"custom_id must be {ComponentLimits.custom_id_max.value} characters or fewer"
+                f"custom_id must be {ComponentLimits.CUSTOM_ID_MAX} characters or fewer"
             )
         if custom_id is not None and url is not None:
             raise TypeError("cannot mix both url and custom_id with Button")
@@ -213,9 +213,9 @@ def custom_id(self) -> str | None:
     def custom_id(self, value: str | None):
         if value is not None and not isinstance(value, str):
             raise TypeError("custom_id must be None or str")
-        if value and len(value) > ComponentLimits.custom_id_max.value:
+        if value and len(value) > ComponentLimits.CUSTOM_ID_MAX:
             raise ValueError(
-                f"custom_id must be {ComponentLimits.custom_id_max.value} characters or fewer"
+                f"custom_id must be {ComponentLimits.CUSTOM_ID_MAX} characters or fewer"
             )
         self.underlying.custom_id = value
         self._provided_custom_id = value is not None
@@ -247,9 +247,9 @@ def label(self) -> str | None:
 
     @label.setter
     def label(self, value: str | None):
-        if value and len(str(value)) > ComponentLimits.button_label_max.value:
+        if value and len(str(value)) > ComponentLimits.BUTTON_LABEL_MAX:
             raise ValueError(
-                f"label must be {ComponentLimits.button_label_max.value} characters or fewer"
+                f"label must be {ComponentLimits.BUTTON_LABEL_MAX} characters or fewer"
             )
         self.underlying.label = str(value) if value is not None else value
 

discord/ui/checkbox.py

@@ -28,7 +28,8 @@
 from typing import TYPE_CHECKING
 
 from ..components import Checkbox as CheckboxComponent
-from ..enums import ComponentLimits, ComponentType
+from .core import ComponentLimits
+from ..enums import ComponentType
 from .item import ModalItem
 
 __all__ = ("Checkbox",)
@@ -105,9 +106,9 @@ def custom_id(self) -> str:
     def custom_id(self, value: str):
         if not isinstance(value, str):
             raise TypeError(f"custom_id must be str not {value.__class__.__name__}")
-        if len(value) > ComponentLimits.custom_id_max.value:
+        if len(value) > ComponentLimits.CUSTOM_ID_MAX:
             raise ValueError(
-                f"custom_id must be {ComponentLimits.custom_id_max.value} characters or fewer"
+                f"custom_id must be {ComponentLimits.CUSTOM_ID_MAX} characters or fewer"
             )
         self.underlying.custom_id = value