feat: ✨Add BaseEmoji.extension and fix animated emoji downloads (#3055)

* ✨🐛 Add extension property and fix animated emoji url

* Update changelog accordingly

* style(pre-commit): auto fixes from pre-commit.com hooks

* 📝 Add versionadded

* Apply change requests

Co-authored-by: Paillat-dev <me@paillat.dev>

* style(pre-commit): auto fixes from pre-commit.com hooks

* Apply change requests 2

Co-authored-by: Paillat-dev <me@paillat.dev>

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Paillat-dev <me@paillat.dev>

Author: 3 people

CHANGELOG.md

@@ -12,6 +12,9 @@ These changes are available on the `master` branch, but have not yet been releas
 
 ### Added
 
+- Added `.extension` attribute to emojis to get their file extension.
+  ([#3055](https://github.com/Pycord-Development/pycord/pull/3055))
+
 ### Changed
 
 - Updated `Role.is_assignable()` to also check whether the bot has the `MANAGE_ROLES`
@@ -21,6 +24,9 @@ These changes are available on the `master` branch, but have not yet been releas
 
 - Fixed `RawMessageUpdateEvent.cached_message` being always `None` even when the message
   was cached. ([#3038](https://github.com/Pycord-Development/pycord/pull/3038))
+- Fixed downloading animated emojis which were originally uploaded as WebP files by
+  changing the `.url` extension of animated emojis from .gif to .webp.
+  ([#3055](https://github.com/Pycord-Development/pycord/pull/3055))
 
 ### Deprecated
 

discord/emoji.py

@@ -25,7 +25,7 @@
 
 from __future__ import annotations
 
-from typing import TYPE_CHECKING, Any, Iterator
+from typing import TYPE_CHECKING, Any, Iterator, Literal
 
 from .asset import Asset, AssetMixin
 from .partial_emoji import PartialEmoji, _EmojiTag
@@ -106,8 +106,10 @@ def created_at(self) -> datetime:
     @property
     def url(self) -> str:
         """Returns the URL of the emoji."""
-        fmt = "gif" if self.animated else "png"
-        return f"{Asset.BASE}/emojis/{self.id}.{fmt}"
+        url = f"{Asset.BASE}/emojis/{self.id}.{self.extension}"
+        if self.animated:
+            url += "?animated=true"
+        return url
 
     @property
     def mention(self) -> str:
@@ -116,6 +118,14 @@ def mention(self) -> str:
             return f"<a:{self.name}:{self.id}>"
         return f"<:{self.name}:{self.id}>"
 
+    @property
+    def extension(self) -> Literal["webp", "png"]:
+        """Return the file extension of the emoji.
+
+        .. versionadded:: 2.7.1
+        """
+        return "webp" if self.animated else "png"
+
 
 class GuildEmoji(BaseEmoji):
     """Represents a custom emoji in a guild.

discord/partial_emoji.py

@@ -26,7 +26,7 @@
 from __future__ import annotations
 
 import re
-from typing import TYPE_CHECKING, Any, TypedDict, TypeVar
+from typing import TYPE_CHECKING, Any, Literal, TypedDict, TypeVar
 
 from . import utils
 from .asset import Asset, AssetMixin
@@ -245,8 +245,18 @@ def url(self) -> str:
         if self.is_unicode_emoji():
             return ""
 
-        fmt = "gif" if self.animated else "png"
-        return f"{Asset.BASE}/emojis/{self.id}.{fmt}"
+        url = f"{Asset.BASE}/emojis/{self.id}.{self.extension}"
+        if self.animated:
+            url += "?animated=true"
+        return url
+
+    @property
+    def extension(self) -> Literal["webp", "png"]:
+        """Return the file extension of the emoji.
+
+        .. versionadded:: 2.7.1
+        """
+        return "webp" if self.animated else "png"
 
     async def read(self) -> bytes:
         if self.is_unicode_emoji():