i hate this shit

Refactor PR template enforcement workflow to streamline validation and membership checks.

Signed-off-by: Lala Sabathil <lala@pycord.dev>

Author: Lulalaby

.github/workflows/enforce-pr-template.yml

@@ -29,68 +29,45 @@ jobs:
             echo "number=${{ github.event.pull_request.number }}" >> "$GITHUB_OUTPUT"
           fi
 
-      - name: Load PR details
-        id: load_pr
+      - name: Enforce template
         uses: actions/github-script@v8
         with:
           github-token: ${{ secrets.GITHUB_TOKEN }}
           script: |
             const prNumber = Number('${{ steps.pr.outputs.number }}');
+            const org = 'Pycord-Development';
+            const INVALID_LABEL = 'invalid';
+
+            // 1) Load PR
             const { data: pr } = await github.rest.pulls.get({
               owner: context.repo.owner,
               repo: context.repo.repo,
               pull_number: prNumber,
             });
 
-            core.setOutput('author', pr.user.login);
-            core.setOutput('state', pr.state);
-            core.setOutput('number', pr.number.toString());
-
-      - name: Check if author is org member
-        id: org_check
-        uses: actions/github-script@v8
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            const org = 'Pycord-Development';
-            const username = '${{ steps.load_pr.outputs.author }}';
+            const author = pr.user.login;
 
+            // 2) Check org membership
+            let isMember = false;
             try {
-              await github.rest.orgs.checkMembershipForUser({ org, username });
-              core.setOutput('is_member', 'true');
+              await github.rest.orgs.checkMembershipForUser({ org, username: author });
+              isMember = true;
             } catch (error) {
-              if (error.status === 404) {
-                core.setOutput('is_member', 'false');
-              } else {
+              if (error.status !== 404) {
                 throw error;
               }
             }
 
-      - name: Skip enforcement for org members
-        if: steps.org_check.outputs.is_member == 'true'
-        run: echo "Author is org member; skipping template enforcement."
-
-      - name: Validate PR body against template
-        if: steps.org_check.outputs.is_member == 'false'
-        id: validate
-        uses: actions/github-script@v8
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            const prNumber = Number('${{ steps.load_pr.outputs.number }}');
-
-            // Fetch PR fresh here to safely get the body
-            const { data: pr } = await github.rest.pulls.get({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: prNumber,
-            });
+            if (isMember) {
+              core.info(`Author ${author} is in org ${org}; skipping enforcement.`);
+              return;
+            }
 
+            // 3) Validate body
             const body = (pr.body || '').trim();
-
             const problems = [];
 
-            // Basic length check – adjust as needed
+            // Basic length check – tune as needed
             if (body.length < 150) {
               problems.push('PR description is too short (expected more content based on the template).');
             }
@@ -113,28 +90,13 @@ jobs:
               problems.push('The line "AI Usage has been disclosed." is missing.');
             }
 
-            if (problems.length > 0) {
-              core.setOutput('valid', 'false');
-              core.setOutput('problems', problems.join('\n'));
-            } else {
-              core.setOutput('valid', 'true');
+            if (problems.length === 0) {
+              core.info('PR body passed template validation.');
+              return;
             }
 
-      - name: Handle invalid PR
-        if: steps.org_check.outputs.is_member == 'false' && steps.validate.outputs.valid == 'false'
-        uses: actions/github-script@v8
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            const prNumber = Number('${{ steps.load_pr.outputs.number }}');
-            const problems = '${{ steps.validate.outputs.problems }}';
-            const { data: pr } = await github.rest.pulls.get({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              pull_number: prNumber,
-            });
-
-            const INVALID_LABEL = 'invalid';
+            // 4) If invalid: label, comment, close, and fail
+            core.info('Template validation failed. Applying actions.');
 
             const existingLabels = (pr.labels || []).map(l => l.name);
             if (!existingLabels.includes(INVALID_LABEL)) {
@@ -146,6 +108,8 @@ jobs:
               });
             }
 
+            const problemsBlock = problems.join('\n');
+
             await github.rest.issues.createComment({
               owner: context.repo.owner,
               repo: context.repo.repo,
@@ -158,7 +122,7 @@ jobs:
                 'Problems detected:',
                 '',
                 '```',
-                problems,
+                problemsBlock,
                 '```',
               ].join('\n'),
             });
@@ -173,7 +137,3 @@ jobs:
             }
 
             core.setFailed('PR does not follow the required template.');
-
-      - name: Validation passed
-        if: steps.org_check.outputs.is_member == 'false' && steps.validate.outputs.valid == 'true'
-        run: echo "PR template validation passed for non-org member."