Skip to content

Commit f79382a

Browse files
committed
simplify checks
1 parent 0fff7dc commit f79382a

2 files changed

Lines changed: 6 additions & 7 deletions

File tree

discord/guild.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1251,7 +1251,7 @@ def premium_subscriber_role(self) -> Role | None:
12511251
.. versionadded:: 1.6
12521252
"""
12531253
for role in self._roles.values():
1254-
if role.type == RoleType.BOOSTER:
1254+
if role.type is RoleType.BOOSTER:
12551255
return role
12561256
return None
12571257

discord/role.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -563,7 +563,7 @@ def is_bot_managed(self) -> bool:
563563
564564
.. versionadded:: 1.6
565565
"""
566-
return self.tags is not None and self.tags.type == RoleType.APPLICATION
566+
return self.type is RoleType.APPLICATION
567567

568568
@deprecated(
569569
"Role.is_premium_subscriber is deprecated since version 2.8, consider using Role.type instead."
@@ -576,7 +576,7 @@ def is_premium_subscriber(self) -> bool:
576576
577577
.. versionadded:: 1.6
578578
"""
579-
return self.tags is not None and self.tags.type == RoleType.BOOSTER
579+
return self.type is RoleType.BOOSTER
580580

581581
@deprecated(
582582
"Role.is_integration is deprecated since version 2.8, consider using Role.type instead."
@@ -590,7 +590,7 @@ def is_integration(self) -> bool:
590590
591591
.. versionadded:: 1.6
592592
"""
593-
return self.tags is not None and self.tags.type == RoleType.INTEGRATION
593+
return self.type is RoleType.INTEGRATION
594594

595595
def is_assignable(self) -> bool:
596596
"""Whether the role is able to be assigned or removed by the bot. This checks whether all of the following conditions are true:
@@ -631,8 +631,7 @@ def is_available_for_purchase(self) -> bool:
631631
.. versionadded:: 2.7
632632
"""
633633
return (
634-
self.tags is not None
635-
and self.tags.type == RoleType.PREMIUM_SUBSCRIPTION_TIER
634+
self.type is RoleType.PREMIUM_SUBSCRIPTION_TIER
636635
)
637636

638637
@deprecated(
@@ -646,7 +645,7 @@ def is_guild_connections_role(self) -> bool:
646645
647646
.. versionadded:: 2.7
648647
"""
649-
return self.tags is not None and self.tags.type == RoleType.CONNECTION
648+
return self.type is RoleType.CONNECTION
650649

651650
@property
652651
def permissions(self) -> Permissions:

0 commit comments

Comments
 (0)