fix: Unify API and gateway version constants (#3080)

* fix: Unify API and gateway version constants

Introduced a new constants module to define API_VERSION and GATEWAY_VERSION, and updated gateway and HTTP modules to use these shared constants. This prevents version drift between REST and gateway usage. Updated the changelog to reflect this change.

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: Lulalaby

CHANGELOG.md

@@ -19,6 +19,9 @@ These changes are available on the `master` branch, but have not yet been releas
 
 - Updated `Role.is_assignable()` to also check whether the bot has the `MANAGE_ROLES`
   permission. ([#3048](https://github.com/Pycord-Development/pycord/pull/3048))
+- Unified HTTP and voice gateway to use shared API version constants (v10) to avoid
+  drift between REST and gateway versions.
+  ([#3080](https://github.com/Pycord-Development/pycord/pull/3080))
 
 ### Fixed
 

discord/constants.py

@@ -0,0 +1,28 @@
+"""
+The MIT License (MIT)
+
+Copyright (c) 2021-present Pycord Development
+
+Permission is hereby granted, free of charge, to any person obtaining a
+copy of this software and associated documentation files (the "Software"),
+to deal in the Software without restriction, including without limitation
+the rights to use, copy, modify, merge, publish, distribute, sublicense,
+and/or sell copies of the Software, and to permit persons to whom the
+Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+DEALINGS IN THE SOFTWARE.
+"""
+
+from __future__ import annotations
+
+API_VERSION: int = 10
+GATEWAY_VERSION: int = API_VERSION

discord/gateway.py

@@ -41,6 +41,7 @@
 
 from . import utils
 from .activity import BaseActivity
+from .constants import GATEWAY_VERSION
 from .enums import SpeakingState
 from .errors import ConnectionClosed, InvalidArgument
 
@@ -420,7 +421,6 @@ async def identify(self):
                 },
                 "compress": True,
                 "large_threshold": 250,
-                "v": 3,
             },
         }
 
@@ -845,7 +845,7 @@ async def identify(self):
     @classmethod
     async def from_client(cls, client, *, resume=False, hook=None):
         """Creates a voice websocket for the :class:`VoiceClient`."""
-        gateway = f"wss://{client.endpoint}/?v=8"
+        gateway = f"wss://{client.endpoint}/?v={GATEWAY_VERSION}&encoding=json"
         http = client._state.http
         socket = await http.ws_connect(gateway, compress=15)
         ws = cls(socket, loop=client.loop, hook=hook)

discord/http.py

@@ -43,6 +43,7 @@
 import aiohttp
 
 from . import __version__, utils
+from .constants import API_VERSION
 from .errors import (
     DiscordServerError,
     Forbidden,
@@ -100,8 +101,6 @@
     MU = TypeVar("MU", bound="MaybeUnlock")
     Response = Coroutine[Any, Any, T]
 
-API_VERSION: int = 10
-
 
 async def json_or_text(response: aiohttp.ClientResponse) -> dict[str, Any] | str:
     text = await response.text(encoding="utf-8")