Skip to content

feat: ✨ Soundboard#2623

Merged
Lulalaby merged 53 commits into
Pycord-Development:masterfrom
Paillat-dev:soundboard
Aug 30, 2025
Merged

feat: ✨ Soundboard#2623
Lulalaby merged 53 commits into
Pycord-Development:masterfrom
Paillat-dev:soundboard

Conversation

@Paillat-dev
Copy link
Copy Markdown
Member

@Paillat-dev Paillat-dev commented Oct 24, 2024

Summary

Soundboard

Follows up on #2321
Fixes #2216

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Paillat-dev Paillat-dev changed the title Soundboard feat: Soundboard Oct 24, 2024
@Paillat-dev
Copy link
Copy Markdown
Member Author

Paillat-dev commented Oct 24, 2024

To be implemented

  • MORE_SOUNDBOARD guild feature flag in Guild.soundboard_limit and Guild.features
  • SOUNDBOARD guild feature flag in Guild.features
  • GET /soundboard-default-sounds in Client.fetch_default_sounds
  • GET /guilds/{guild.id}/soundboard-sounds in Guild.fetch_sounds
  • GET /guilds/{guild.id}/soundboard-sounds/{sound.id} in Guild.fetch_sound
  • POST /channels/{channel.id}/send-soundboard-sound in VoiceChannel.send_soundboard_sound
  • POST /guilds/{guild.id}/soundboard-sounds in Guild.create_sound
  • PATCH /guilds/{guild.id}/soundboard-sounds/{sound.id} in SoundboardSound.edit
  • DELETE /guilds/{guild.id}/soundboard-sounds/{sound.id} in SoundboardSound.delete
  • GUILD_SOUNDBOARD_SOUND_CREATE (Guild soundboard sound was created)
  • GUILD_SOUNDBOARD_SOUND_UPDATE (Guild soundboard sound was updated)
  • GUILD_SOUNDBOARD_SOUND_DELETE (Guild soundboard sound was deleted)
  • GUILD_SOUNDBOARD_SOUNDS_UPDATE (Guild soundboard sounds were updated)
  • VOICE_CHANNEL_EFFECT_SEND (Someone sent an effect in a voice channel the current user is connected to) in on_voice_channel_effect_send

Todo

  • Docstrings
  • Example &/ guide
  • Cleanup and triple check the old code
  • __repr__

@Paillat-dev Paillat-dev force-pushed the soundboard branch 2 times, most recently from 0547338 to 8811e76 Compare October 24, 2024 22:20
@Paillat-dev
Copy link
Copy Markdown
Member Author

Paillat-dev commented Oct 24, 2024

@Lulalaby You mentioned in #2216

Note: soundboard sounds can not be dispatched by bots. Only managed.

It's curious that they documented /channels/{channel.id}/send-soundboard-sound (https://discord.com/developers/docs/resources/soundboard#send-soundboard-sound) then... Did that change in the mean time ?

Comment thread discord/soundboard.py Outdated
@Lulalaby
Copy link
Copy Markdown
Member

yeah, advaith changed it

@Paillat-dev Paillat-dev force-pushed the soundboard branch 4 times, most recently from 4babd81 to 8a9ec19 Compare October 25, 2024 13:22
@Paillat-dev Paillat-dev marked this pull request as ready for review October 25, 2024 13:50
@Paillat-dev Paillat-dev requested a review from a team as a code owner October 25, 2024 13:50
@pullapprove4 pullapprove4 Bot requested a review from BobDotCom October 25, 2024 13:50
Copy link
Copy Markdown
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Objects need to be added to docs

@Paillat-dev
Copy link
Copy Markdown
Member Author

There.

@Lumabots
Copy link
Copy Markdown
Contributor

could this pls review and merged ? it been almost a year

@Lulalaby
Copy link
Copy Markdown
Member

Lulalaby commented Aug 2, 2025

Merge conflicts

auto-merge was automatically disabled August 2, 2025 15:50

Head branch was pushed to by a user without write access

@Paillat-dev
Copy link
Copy Markdown
Member Author

@Lulalaby should be good

@Paillat-dev Paillat-dev dismissed stale reviews from Lumabots and JustaSqu1d via 5008db3 August 3, 2025 12:01
@Paillat-dev Paillat-dev requested a review from a team as a code owner August 28, 2025 21:46
@pullapprove4
Copy link
Copy Markdown

pullapprove4 Bot commented Aug 28, 2025

This pull request is in the In review step of the Pycord workflow.

Waiting for review from these teams:

It is @Paillat-dev's turn to determine what is required to move this PR forward.

@Paillat-dev
Copy link
Copy Markdown
Member Author

It is required for this PR to move forward to get some reviews

Copy link
Copy Markdown
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from api side

@Lulalaby
Copy link
Copy Markdown
Member

@Lumabots do u have time to test it rq

@Lulalaby Lulalaby dismissed stale reviews from Dorukyum and plun1331 August 30, 2025 14:22

x

@Lumabots
Copy link
Copy Markdown
Contributor

@Lumabots do u have time to test it rq

Give me 5min and I'll test it

@Lumabots
Copy link
Copy Markdown
Contributor

tested send_soundboard_sound, fetch_default_sounds, get_sound, guild.sounds and everything works fine

@Lulalaby
Copy link
Copy Markdown
Member

then approve

@Lulalaby Lulalaby added this to the v2.7 milestone Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Soundboard

8 participants