feat: ✨ Parse data as message in parse_message_update instead of using _update#2780
Merged
Lulalaby merged 11 commits intoSep 3, 2025
Merged
Conversation
9 tasks
VincentRPS
previously requested changes
May 22, 2025
Signed-off-by: Paillat <me@paillat.dev>
Lulalaby
previously approved these changes
Aug 2, 2025
Lulalaby
reviewed
Aug 2, 2025
Signed-off-by: Paillat <paillat@pycord.dev>
Lulalaby
previously approved these changes
Aug 28, 2025
Lulalaby
requested review from
JustaSqu1d
and removed request for
Dorukyum and
VincentRPS
Signed-off-by: Paillat <paillat@pycord.dev>
Signed-off-by: Lala Sabathil <lala@pycord.dev>
Soheab
previously requested changes
Sep 1, 2025
Contributor
Soheab
left a comment
Soheab
left a comment
There was a problem hiding this comment.
Not a fan of the attribute name new_message, but it makes sense and is fine for now. Good stuff.
Co-authored-by: Soheab <33902984+Soheab@users.noreply.github.com> Signed-off-by: Paillat <jeremiecotti@ik.me>
Lulalaby
approved these changes
Sep 3, 2025
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Superseeds: #2778 - no need to merge both.
Fixes #2777
Message update contains a full message object - no need to use that messy update logic. See:
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.