fix: GuildSchedule not being cached correctly + missing fields by Lumabots · Pull Request #3025 · Pycord-Development/pycord

Lumabots · 2025-12-09T19:51:26Z

Summary

summary is not complete, just check the code

Added
New Enums :
ScheduledEventRecurrenceFrequency (yearly, monthly, weekly, daily)
ScheduledEventRecurrenceWeekday (monday-sunday)
ScheduledEventRecurrenceMonth (january-december)

New Classes:
ScheduledEventEntityMetadata (location)
ScheduledEventRecurrenceNWeekday Represents n-weekday entries (e.g., "1st Tuesday")
ScheduledEventRecurrenceRule: Full recurrence rule with validation

Auto-validates on to_payload() serialization
New fields Guild.create_scheduled_event():

well at this point just read the code

Enforces Discord's constraints:

Frequency-specific field combinations
Mutually exclusive field checks
Valid weekday set validation for daily events
Required field enforcement for yearly events

Information

This PR fixes an issue. on_scheduled_event_delete event parameter is useless #1709
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.
AI Usage has been disclosed.

…reason

…types

…from audit logs

…ation tests

pycord-app · 2025-12-09T19:51:30Z

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3025/head:pr-3025
git checkout pr-3025

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3025/head

Lumabots · 2025-12-09T19:53:17Z

Audit Logs still need to be rework (i didnt understand how it work yet)

Lumabots · 2025-12-10T07:09:48Z

should we use use_cache_on_error, instead of only use cache ? that way we will be able to fetch first and if unavailable we will get
Open of better variable name

Paillat-dev

If possible, make this pr not interfere with the recurrence one from anonymous. There will probably be merge conflicts once that one is merged, but they shouldn't both implement recurrence in a different way.

discord/enums.py

discord/scheduled_events.py

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lumabots · 2025-12-12T06:46:23Z

If possible, make this pr not interfere with the recurrence one from anonymous. There will probably be merge conflicts once that one is merged, but they shouldn't both implement recurrence in a different way.

when anonymous pr will be merged i'll edit it to make it work

Lulalaby · 2025-12-12T08:29:18Z

fixed ur fux

Paillat-dev · 2026-02-28T19:33:47Z

@Lumabots Your PR uses utils.deprecated. Use @typing_extensions.deprecated instead.

…str, str]

Lulalaby · 2026-03-02T23:11:25Z

discord/guild.py

+        entity_type: ScheduledEventEntityType = MISSING,
+        entity_metadata: ScheduledEventEntityMetadata | None = MISSING,
+        channel_id: int = MISSING,
+        privacy_level: ScheduledEventPrivacyLevel = ScheduledEventPrivacyLevel.guild_only,


privacy_level is deprecated and ignored by the api

Lulalaby · 2026-03-02T23:11:32Z

discord/guild.py

+        entity_type: ScheduledEventEntityType = MISSING,
+        entity_metadata: ScheduledEventEntityMetadata | None = MISSING,
+        channel_id: int = MISSING,
        privacy_level: ScheduledEventPrivacyLevel = ScheduledEventPrivacyLevel.guild_only,


Here it wasn't added tho so we can't remove it. But you can warn_deprecated @Lumabots when it's not MISSING

deprecate it and avoid emitting it in calls

github-actions · 2026-04-13T15:37:59Z

This pull request does not follow the required pull request template.

Please use the default template (PULL_REQUEST_TEMPLATE.md) and fill out all required sections.

Problems detected:

The line "AI Usage has been disclosed." is missing.

Signed-off-by: Paillat <paillat@pycord.dev>

Paillat-dev · 2026-04-13T16:08:30Z

discord/scheduled_events.py

+    @typing_extensions.deprecated(
+        "location is deprecated since 2.7 and will be removed in 3.0, consider using entity_metadata instead",
+    )
+    def location(self) -> ScheduledEventLocation | None:


This property never returns anything. Also this can lead to infinite reucrsion (? I think) since it sets self.location inside itself.

Paillat-dev · 2026-04-13T16:11:51Z

discord/scheduled_events.py

            f"creator_id={self.creator_id}>"
+            f"channel_id={self.channel_id}>"


Suggested change

f"creator_id={self.creator_id}>"

f"channel_id={self.channel_id}>"

f"creator_id={self.creator_id} "

f"channel_id={self.channel_id}>"

Also this uses deprecated attributes like self.location and self.user_count

Paillat-dev · 2026-04-13T16:14:12Z

discord/iterators.py


+    async def _fill_from_cache(self):
+        """Fill subscribers queue from cached user IDs."""
+        cached_user_ids = list(self.event._cached_subscribers.keys())


event._cached_subscribers is set[int] which doesn't have keys

Paillat-dev · 2026-04-13T16:18:55Z

discord/guild.py

-            "scheduled_start_time": start_time.isoformat(),
-            "privacy_level": int(privacy_level),
+            "scheduled_start_time": scheduled_start_time.isoformat(),
+            "entity_type": int(entity_type),


This could be missing which would lead here to an error bc of int(MISSING)

Paillat-dev · 2026-04-13T16:20:58Z

discord/scheduled_events.py

+    def location(self) -> ScheduledEventLocation | None:
+        """Returns the location of the event."""
+        if self.channel_id is None:
+            self.location = ScheduledEventLocation(


So basically this is deprecated but then it means accessing the deprecated .location will cause two warnings. Maybe add an _internal: True which doesn't warn_deprecated in the init or something.

Lumabots added 6 commits December 9, 2025 15:49

at first i only wanted to add cached members...

43227c4

correcting some bs, like some unknow type added for i dont know what …

fe47678

…reason

use discord variable name, try an implementation for audit logs

fff9b3b

feat: add recurrence support for scheduled events with new enums and …

9e6a986

…types

refactor: remove ScheduledEventLocation class and related attributes …

7b2c31f

…from audit logs

feat: enhance scheduled event recurrence with validation and serializ…

5a2581e

…ation tests

Lumabots requested a review from a team as a code owner December 9, 2025 19:51

pullapprove4 bot requested a review from Lulalaby December 9, 2025 19:51

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Dec 9, 2025

Lumabots and others added 2 commits December 9, 2025 20:51

Merge branch 'master' into on_scheduled_event_delete

973a3d2

style(pre-commit): auto fixes from pre-commit.com hooks

9d1d5d7

Lumabots and others added 2 commits December 10, 2025 13:39

revert breaking change

8c85a05

style(pre-commit): auto fixes from pre-commit.com hooks

40d79b6

Paillat-dev changed the title ~~feat: Full rework of GuildSchedule~~ fux: GuildSchedule not being cached correctly Dec 10, 2025

Paillat-dev requested changes Dec 10, 2025

View reviewed changes

discord/enums.py Show resolved Hide resolved

discord/enums.py Outdated Show resolved Hide resolved

discord/scheduled_events.py Show resolved Hide resolved

discord/scheduled_events.py Outdated Show resolved Hide resolved

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Dec 10, 2025

Paillat-dev added API reflection Discord API isn't correctly reflected hold: testing This pull request requires further testing priority: medium Medium Priority labels Dec 10, 2025

Update discord/enums.py

b5dc3e9

Co-authored-by: Paillat <paillat@pycord.dev> Signed-off-by: Lumouille <144063653+Lumabots@users.noreply.github.com>

Lulalaby changed the title ~~fux: GuildSchedule not being cached correctly~~ fix: GuildSchedule not being cached correctly Dec 12, 2025

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Feb 15, 2026

Paillat-dev modified the milestones: v2.8rc.1, v2.8.0 Feb 16, 2026

Paillat-dev requested a review from Soheab February 28, 2026 16:31

Merge branch 'master' into on_scheduled_event_delete

294dc39

Lumabots added 3 commits March 2, 2026 23:44

refactor: Update deprecated property decorators to use typing_extensions

ef960ff

fix: Update type hint for _transform_entity_metadata to specify dict[…

8c4c395

…str, str]

Merge branch 'master' into on_scheduled_event_delete

b1bbf52

Paillat-dev requested review from JustaSqu1d and plun1331 March 2, 2026 22:59

style(pre-commit): auto fixes from pre-commit.com hooks

ddd0c0e

Lulalaby requested changes Mar 2, 2026

View reviewed changes

Lulalaby added this to Pycord Mar 18, 2026

github-project-automation bot moved this to Todo in Pycord Mar 18, 2026

Paillat-dev requested review from a team March 24, 2026 10:22

fix: Update privacy_level default to MISSING and add deprecation warning

c78136d

github-actions bot added the invalid This doesn't seem right label Apr 13, 2026

github-actions bot closed this Apr 13, 2026

github-actions bot locked as spam and limited conversation to collaborators Apr 13, 2026

github-project-automation bot moved this from Todo to Done in Pycord Apr 13, 2026

Paillat-dev reopened this Apr 13, 2026

Paillat-dev removed the invalid This doesn't seem right label Apr 13, 2026

Pycord-Development unlocked this conversation Apr 13, 2026

Paillat-dev and others added 2 commits April 13, 2026 17:48

Merge branch 'master' into on_scheduled_event_delete

7022e67

Signed-off-by: Paillat <paillat@pycord.dev>

style(pre-commit): auto fixes from pre-commit.com hooks

b86cd07

Paillat-dev requested changes Apr 13, 2026

View reviewed changes

		f"creator_id={self.creator_id}>"
		f"channel_id={self.channel_id}>"

Uh oh!

Conversation

Lumabots commented Dec 9, 2025 • edited by Paillat-dev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Information

Checklist

Uh oh!

pycord-app bot commented Dec 9, 2025

Uh oh!

Lumabots commented Dec 9, 2025

Uh oh!

Lumabots commented Dec 10, 2025

Uh oh!

Paillat-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lumabots commented Dec 12, 2025

Uh oh!

Lulalaby commented Dec 12, 2025

Uh oh!

Paillat-dev commented Feb 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 13, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Lumabots commented Dec 9, 2025 •

edited by Paillat-dev

Loading