Skip to content

docs: Correct type for ui.Container.add_file()#3161

Merged
Lulalaby merged 1 commit intoPycord-Development:masterfrom
Revnoplex:fix/container-file-documentation-typing
Mar 20, 2026
Merged

docs: Correct type for ui.Container.add_file()#3161
Lulalaby merged 1 commit intoPycord-Development:masterfrom
Revnoplex:fix/container-file-documentation-typing

Conversation

@Revnoplex
Copy link
Copy Markdown
Contributor

@Revnoplex Revnoplex commented Mar 20, 2026

Caution

Code freeze is active

Summary

discord.ui.Container.add_file() wrongly typed as adding a discord.ui.TextDisplay instead of discord.ui.File.
This pr corrects this type

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@Revnoplex Revnoplex requested a review from a team as a code owner March 20, 2026 13:31
@github-project-automation github-project-automation bot moved this to Todo in Pycord Mar 20, 2026
@pycord-app
Copy link
Copy Markdown

pycord-app bot commented Mar 20, 2026

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3161/head:pr-3161
git checkout pr-3161

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3161/head

@Revnoplex
Copy link
Copy Markdown
Contributor Author

oops i forgot to add a summary

@JustaSqu1d JustaSqu1d changed the title fix: Correct type for ui.Container.add_file() docs: correct type for ui.Container.add_file() Mar 20, 2026
@JustaSqu1d JustaSqu1d added the documentation Improvements or additions to documentation label Mar 20, 2026
@Revnoplex Revnoplex force-pushed the fix/container-file-documentation-typing branch from 8ee8871 to 43a32fb Compare March 20, 2026 13:34
@Revnoplex Revnoplex changed the title docs: correct type for ui.Container.add_file() docs: Correct type for ui.Container.add_file() Mar 20, 2026
@Lulalaby Lulalaby merged commit 2e6c262 into Pycord-Development:master Mar 20, 2026
29 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Pycord Mar 20, 2026
@Paillat-dev
Copy link
Copy Markdown
Member

Paillat-dev commented Mar 20, 2026

YOu just made me need to cherry pick tomorrow /j

@JustaSqu1d
Copy link
Copy Markdown
Member

YOu just made me need to cherry pick tomorrow /j

Your fault for not thoroughly reviewing an earlier PR

@Lulalaby
Copy link
Copy Markdown
Member

cry about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants