Skip to content

fix: correct default type from ellipsis to none#3171

Merged
plun1331 merged 3 commits intomasterfrom
fix-ellipsis-default-values
Mar 23, 2026
Merged

fix: correct default type from ellipsis to none#3171
plun1331 merged 3 commits intomasterfrom
fix-ellipsis-default-values

Conversation

@plun1331
Copy link
Copy Markdown
Member

Caution

Feature freeze is active, as described by our Release Schedule.

Summary

Fixes #3170

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@plun1331 plun1331 requested review from a team and Dorukyum March 23, 2026 17:58
@github-project-automation github-project-automation bot moved this to Todo in Pycord Mar 23, 2026
@plun1331 plun1331 requested a review from Paillat-dev March 23, 2026 17:58
@plun1331 plun1331 requested a review from a team as a code owner March 23, 2026 17:58
@pycord-app
Copy link
Copy Markdown

pycord-app bot commented Mar 23, 2026

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3171/head:pr-3171
git checkout pr-3171

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3171/head

Fixed a TypeError in Label.set_select when default_values are not provided.

Signed-off-by: plun1331 <plun1331@gmail.com>
@plun1331 plun1331 requested a review from a team as a code owner March 23, 2026 18:01
@plun1331 plun1331 requested a review from EmmmaTech March 23, 2026 18:01
@plun1331 plun1331 self-assigned this Mar 23, 2026
@plun1331 plun1331 added bug Something isn't working priority: medium Medium Priority priority: low Low Priority and removed priority: medium Medium Priority labels Mar 23, 2026
@plun1331 plun1331 moved this from Todo to In Progress in Pycord Mar 23, 2026
@plun1331 plun1331 added this to the v2.8.0 milestone Mar 23, 2026
@plun1331 plun1331 enabled auto-merge (squash) March 23, 2026 18:07
Copy link
Copy Markdown
Member

@Paillat-dev Paillat-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plun1331 plun1331 merged commit 5cda9e5 into master Mar 23, 2026
27 checks passed
@plun1331 plun1331 deleted the fix-ellipsis-default-values branch March 23, 2026 18:13
@github-project-automation github-project-automation bot moved this from In Progress to Done in Pycord Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority: low Low Priority

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Failing to provide default values for menu select in modal crashes the interaction

2 participants